Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Tom Tromey <tom@tromey.com>,  <gdb-patches@sourceware.org>
Subject: Re: [RFA] Remove a VEC from type.c
Date: Tue, 29 May 2018 17:58:00 -0000	[thread overview]
Message-ID: <87o9gycq7h.fsf@tromey.com> (raw)
In-Reply-To: <b7a0bd60-5996-334a-25d5-1228489a7fb0@ericsson.com> (Simon	Marchi's message of "Tue, 29 May 2018 11:52:08 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

>> +/* Compares type A to type B returns true if the represent the same
>> +   type, false otherwise.  */

Simon> Could you fix the "the" -> "they" typo at the same time?  It wouldn't hurt to
Simon> improve the syntax as well, it reads a bit weird.

I fixed this.

Simon> Not really related to your patch, but I think we could reduce the number of
Simon> required comparisons/arithmetic operations by doing
Simon> if (s == NULL || t == NULL)
Simon>   return s == t;
Simon> return strcmp (s, t) == 0;

I did this too.  I went to look at the assembly but with the new,
shorter version, it is always inlined.

I'm going to check this in momentarily.

Tom


      reply	other threads:[~2018-05-29 17:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 15:13 Tom Tromey
2018-05-29 15:58 ` Simon Marchi
2018-05-29 17:58   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9gycq7h.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox