From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39059 invoked by alias); 29 May 2018 17:43:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39036 invoked by uid 89); 29 May 2018 17:43:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 17:43:48 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 6AD2C4E982 for ; Tue, 29 May 2018 12:43:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id NiexfUNIpBcCXNiexfN9v1; Tue, 29 May 2018 12:43:47 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:54448 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fNiex-000bJe-2D; Tue, 29 May 2018 12:43:47 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [RFA] Remove a VEC from type.c References: <20180529151002.5700-1-tom@tromey.com> Date: Tue, 29 May 2018 17:58:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 29 May 2018 11:52:08 -0400") Message-ID: <87o9gycq7h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fNiex-000bJe-2D X-Source-Sender: 174-29-44-154.hlrn.qwest.net (pokyo) [174.29.44.154]:54448 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00774.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> +/* Compares type A to type B returns true if the represent the same >> + type, false otherwise. */ Simon> Could you fix the "the" -> "they" typo at the same time? It wouldn't hurt to Simon> improve the syntax as well, it reads a bit weird. I fixed this. Simon> Not really related to your patch, but I think we could reduce the number of Simon> required comparisons/arithmetic operations by doing Simon> if (s == NULL || t == NULL) Simon> return s == t; Simon> return strcmp (s, t) == 0; I did this too. I went to look at the assembly but with the new, shorter version, it is always inlined. I'm going to check this in momentarily. Tom