From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [RFAv2] Fix buffer overflow regression due to minsym malloc-ed instead of obstack-ed.
Date: Tue, 26 Mar 2019 19:20:00 -0000 [thread overview]
Message-ID: <87o95x5tok.fsf@tromey.com> (raw)
In-Reply-To: <69c0a306-5829-54c4-d2a6-1b29be829100@simark.ca> (Simon Marchi's message of "Tue, 26 Mar 2019 14:46:14 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> and have the '< last' conditions below then be '<= last'.
>>
>> That makes more clear for me that we handle the last
>> element of the array.
Simon> This, or name the variable "past_the_end" or something like that.
Perhaps I'll use past_the_end and then use !=, since that seems to be
the C++ iterator style.
Tom
prev parent reply other threads:[~2019-03-26 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 9:19 Philippe Waroquiers
2019-03-25 15:31 ` Tom Tromey
2019-03-25 19:54 ` Philippe Waroquiers
2019-03-26 18:46 ` Simon Marchi
2019-03-26 19:20 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o95x5tok.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox