From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95766 invoked by alias); 26 Mar 2019 19:20:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95205 invoked by uid 89); 26 Mar 2019 19:20:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*Ad:D*be X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Mar 2019 19:20:31 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id AB2E4A4FAA for ; Tue, 26 Mar 2019 14:20:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8rcbhYvxs2PzO8rcbhrnO0; Tue, 26 Mar 2019 14:20:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bCFBvLJlITn3pdJPBAOIGCVyOTr4w4asmFgsE3VbYGY=; b=Mblie6MPOWZ87i+eQTNDg7Bm3Y DYLJTXJ8O5+paA4WOvs0ZdDqasRluvjtm7FajAqIpjBD/35p/jLmKndxkAAReqsBjIvte7qFuW8Gg QhD/qh4TnWIZsxJBKjorYF8Su; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:37052 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h8rca-002Efb-Qr; Tue, 26 Mar 2019 14:20:28 -0500 From: Tom Tromey To: Simon Marchi Cc: Philippe Waroquiers , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFAv2] Fix buffer overflow regression due to minsym malloc-ed instead of obstack-ed. References: <20190324091856.2529-1-philippe.waroquiers@skynet.be> <87h8brj7ie.fsf@tromey.com> <1553543645.1504.7.camel@skynet.be> <69c0a306-5829-54c4-d2a6-1b29be829100@simark.ca> Date: Tue, 26 Mar 2019 19:20:00 -0000 In-Reply-To: <69c0a306-5829-54c4-d2a6-1b29be829100@simark.ca> (Simon Marchi's message of "Tue, 26 Mar 2019 14:46:14 -0400") Message-ID: <87o95x5tok.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00607.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> and have the '< last' conditions below then be '<= last'. >> >> That makes more clear for me that we handle the last >> element of the array. Simon> This, or name the variable "past_the_end" or something like that. Perhaps I'll use past_the_end and then use !=, since that seems to be the C++ iterator style. Tom