Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [RFAv2 2/2] Add a selftest that checks documentation invariants.
Date: Wed, 07 Aug 2019 02:06:00 -0000	[thread overview]
Message-ID: <87o911g263.fsf@tromey.com> (raw)
In-Reply-To: <1565130113.1435.10.camel@skynet.be> (Philippe Waroquiers's	message of "Wed, 07 Aug 2019 00:21:53 +0200")

Philippe> I have kept the code above, as strchr returns NULL if no \n
Philippe> is found, but it is normal to have a doc with just the
Philippe> first line (not terminated by a LF).
Philippe> In this case, we must still check that we have a . before
Philippe> the terminating null byte.

Thanks, that makes sense.

Tom


      reply	other threads:[~2019-08-07  2:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-03 13:39 [RFAv2 0/2] Make first and last lines of 'command help documentation' consistent + add a test Philippe Waroquiers
2019-08-03 13:39 ` [RFAv2 1/2] Make first and last lines of 'command help documentation' consistent Philippe Waroquiers
2019-08-06 18:30   ` Tom Tromey
2019-08-03 13:39 ` [RFAv2 2/2] Add a selftest that checks documentation invariants Philippe Waroquiers
2019-08-06 18:43   ` Tom Tromey
2019-08-06 22:21     ` Philippe Waroquiers
2019-08-07  2:06       ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o911g263.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox