From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87960 invoked by alias); 7 Aug 2019 02:06:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87900 invoked by uid 89); 7 Aug 2019 02:06:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 02:06:09 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 3A1281157A for ; Tue, 6 Aug 2019 21:05:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vBKwhxkJl2PzOvBKwh1MJy; Tue, 06 Aug 2019 21:05:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XLihXzP1nz9ytwQSmk+6w0/7B7CS0KOtli1dEBJKUiw=; b=cH6Q4az01e7aSlyuckuXo65cyw fGFWbP3cHZjHqkEyjWhoL+UnW3Fxqm3VvdaY2DUk8lwz/hFCoQmircC2wTZxQasX2JoHL6osxxssR 4Quvk9f/EKJ50xN4kqV25BOx4; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:54208 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hvBKv-000Vc6-Vp; Tue, 06 Aug 2019 21:05:58 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFAv2 2/2] Add a selftest that checks documentation invariants. References: <20190803133921.20154-1-philippe.waroquiers@skynet.be> <20190803133921.20154-3-philippe.waroquiers@skynet.be> <874l2u9mah.fsf@tromey.com> <1565130113.1435.10.camel@skynet.be> Date: Wed, 07 Aug 2019 02:06:00 -0000 In-Reply-To: <1565130113.1435.10.camel@skynet.be> (Philippe Waroquiers's message of "Wed, 07 Aug 2019 00:21:53 +0200") Message-ID: <87o911g263.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00165.txt.bz2 Philippe> I have kept the code above, as strchr returns NULL if no \n Philippe> is found, but it is normal to have a doc with just the Philippe> first line (not terminated by a LF). Philippe> In this case, we must still check that we have a . before Philippe> the terminating null byte. Thanks, that makes sense. Tom