From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH] Change the type of copy_names from int to bool
Date: Wed, 11 Sep 2019 17:41:00 -0000 [thread overview]
Message-ID: <87o8zq4to0.fsf@tromey.com> (raw)
In-Reply-To: <20190910204252.218634-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 10 Sep 2019 15:42:52 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> [Does this count as obvious?]
Normally I'd reserve obvious for build breakage or comment fixes or the
like; but I think there's a consensus for bool-ifying, and so this would
be unobjectionable to me at least.
Christian> 2019-09-10 Christian Biesinger <cbiesinger@google.com>
Christian> * dbxread.c (read_dbx_symtab): Update.
Christian> * dwarf2read.c (load_partial_dies): Update.
Christian> * mdebugread.c (parse_partial_symbols): Update.
Christian> (handle_psymbol_enumerators): Update.
Christian> * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
Christian> * psymtab.c (add_psymbol_to_bcache): Likewise.
Christian> (add_psymbol_to_list): Likewise.
Christian> * symtab.c (symbol_set_names): Likewise.
Christian> * symtab.h (symbol_set_names): Likewise.
Christian> * xcoffread.c (scan_xcoff_symtab): Update.
Ok. Thank you.
Tom
next prev parent reply other threads:[~2019-09-11 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 20:42 Christian Biesinger via gdb-patches
2019-09-11 17:41 ` Tom Tromey [this message]
2019-09-11 17:47 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8zq4to0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox