From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16367 invoked by alias); 11 Sep 2019 17:41:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16358 invoked by uid 89); 11 Sep 2019 17:41:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 17:41:38 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 247B02095A0F for ; Wed, 11 Sep 2019 12:41:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 86caiHAp43Qi086caitiJI; Wed, 11 Sep 2019 12:41:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jPR5XNljxQ1qm/vjg/imCFtVXT1WBieWdeswjTzIPPY=; b=cwUldx8cT5o0QaBVWtT1avh5aV aQ+Pm4vgA84MgPuxy40L4OPEKWB1i0hD1DAoLBzjcM9nIsT0zD1yvgKRQYMjbLJaEjwMK4uWGSINX rwYTzb5lItoF+xaHrflqJa5hZ; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:41386 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i86ca-002nc6-9r; Wed, 11 Sep 2019 12:41:36 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] Change the type of copy_names from int to bool References: <20190910204252.218634-1-cbiesinger@google.com> Date: Wed, 11 Sep 2019 17:41:00 -0000 In-Reply-To: <20190910204252.218634-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 10 Sep 2019 15:42:52 -0500") Message-ID: <87o8zq4to0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00203.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> [Does this count as obvious?] Normally I'd reserve obvious for build breakage or comment fixes or the like; but I think there's a consensus for bool-ifying, and so this would be unobjectionable to me at least. Christian> 2019-09-10 Christian Biesinger Christian> * dbxread.c (read_dbx_symtab): Update. Christian> * dwarf2read.c (load_partial_dies): Update. Christian> * mdebugread.c (parse_partial_symbols): Update. Christian> (handle_psymbol_enumerators): Update. Christian> * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool. Christian> * psymtab.c (add_psymbol_to_bcache): Likewise. Christian> (add_psymbol_to_list): Likewise. Christian> * symtab.c (symbol_set_names): Likewise. Christian> * symtab.h (symbol_set_names): Likewise. Christian> * xcoffread.c (scan_xcoff_symtab): Update. Ok. Thank you. Tom