From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: introduce objfile text_section_offset and data_section_offset methods
Date: Thu, 23 Jan 2020 22:45:00 -0000 [thread overview]
Message-ID: <87o8utpzi1.fsf@tromey.com> (raw)
In-Reply-To: <20200114050342.972630-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Tue, 14 Jan 2020 00:03:42 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> The pattern
Simon> objfile-> section_offsets[SECT_OFF_TEXT (objfile)]
Simon> ... appears very often, to get the offset of the text section of an
Simon> objfile. I thought it would be more readable to write it as:
Simon> objfile-> text_section_offset ()
Simon> ... so I added this method and used it where possible. I also added
Simon> data_section_offset, although it is not used as much.
Thanks. This looks good to me.
Tom
next prev parent reply other threads:[~2020-01-23 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 7:02 Simon Marchi
2020-01-23 22:45 ` Tom Tromey [this message]
2020-01-23 22:53 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8utpzi1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox