From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51475 invoked by alias); 23 Jan 2020 22:41:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51467 invoked by uid 89); 23 Jan 2020 22:41:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=HX-Languages-Length:589 X-HELO: gateway21.websitewelcome.com Received: from gator3069.hostgator.com (HELO gateway21.websitewelcome.com) (192.185.45.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jan 2020 22:41:12 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 946C3400EE69C for ; Thu, 23 Jan 2020 16:41:11 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ul9ziq0As32Adul9zizMDc; Thu, 23 Jan 2020 16:41:11 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zIbQJXAFD2e2XBypmwnNl7fDujIabuNNALCEH70FhyE=; b=PmbGOyJsw3KD/HxvezOUBtrnEw aDBNxHtbEhUgl/jtunrz1RKg4jXBoGEfVFx8Z8CWUHOoCSBUznRymXUBhSqplr/OacgDN5U39gVlK fVJnECFtMD5NmwCcWpRkNuvNl; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:57168 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iul9z-001ICT-Bu; Thu, 23 Jan 2020 15:41:11 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: introduce objfile text_section_offset and data_section_offset methods References: <20200114050342.972630-1-simon.marchi@polymtl.ca> Date: Thu, 23 Jan 2020 22:45:00 -0000 In-Reply-To: <20200114050342.972630-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Tue, 14 Jan 2020 00:03:42 -0500") Message-ID: <87o8utpzi1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00767.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> The pattern Simon> objfile-> section_offsets[SECT_OFF_TEXT (objfile)] Simon> ... appears very often, to get the offset of the text section of an Simon> objfile. I thought it would be more readable to write it as: Simon> objfile-> text_section_offset () Simon> ... so I added this method and used it where possible. I also added Simon> data_section_offset, although it is not used as much. Thanks. This looks good to me. Tom