From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>,
Morichetti@sourceware.org, Laurent <Laurent.Morichetti@amd.com>
Subject: Re: [PATCH 4/4] gdb: change regcache list to be a map
Date: Mon, 10 Aug 2020 13:15:26 -0600 [thread overview]
Message-ID: <87o8nijos1.fsf@tromey.com> (raw)
In-Reply-To: <20200720204101.2849535-5-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 20 Jul 2020 16:41:01 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
A bit late on this thread, but OTOH nothing too urgent to say...
Simon> Note: In hash_target_ptid, I am combining hash values from std::hash by
Simon> summing them. I don't think it's ideal, since std::hash is just the
Simon> identity function for base types. But I don't know what would be better
Simon> to reduce the change of collisions. If anybody has a better idea, I'd
Simon> be interested.
You can use fast_hash iteratively. It may not matter though.
Simon> +/* Hash function for target_ptid. */
Simon> +
Simon> +struct hash_target_ptid
Simon> +{
Simon> + size_t operator() (const target_ptid &val) const
Simon> + {
It seems to me that for types that have a single "natural" hash, or a
useful "canonical" hash (i.e., a hash we'd be likely to want to use by
default in the normal case), we could specialize std::hash. For
example, this code could do that.
Tom
next prev parent reply other threads:[~2020-08-10 19:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 20:40 [PATCH 0/4] Regcache fix and optimization Simon Marchi
2020-07-20 20:40 ` [PATCH 1/4] gdb: rename regcache::current_regcache to regcache::regcaches Simon Marchi
2020-07-23 20:01 ` Pedro Alves
2020-07-20 20:40 ` [PATCH 2/4] gdb: move regcache::regcaches to regcache.c Simon Marchi
2020-07-23 20:03 ` Pedro Alves
2020-07-20 20:41 ` [PATCH 3/4] gdb: pass target to thread_ptid_changed observable Simon Marchi
2020-07-23 20:42 ` Pedro Alves
2020-07-30 15:27 ` Simon Marchi
2020-08-05 14:50 ` Pedro Alves
2020-08-05 19:08 ` Simon Marchi
2020-08-05 22:29 ` Pedro Alves
2020-07-20 20:41 ` [PATCH 4/4] gdb: change regcache list to be a map Simon Marchi
2020-07-24 1:53 ` Pedro Alves
2020-07-24 16:59 ` John Baldwin
2020-07-30 16:26 ` Simon Marchi
2020-07-30 16:58 ` Simon Marchi
2020-07-30 17:03 ` Simon Marchi
2020-08-05 18:02 ` Pedro Alves
2020-08-05 20:25 ` Simon Marchi
2020-07-30 17:07 ` Simon Marchi
2020-07-30 18:17 ` Simon Marchi
2020-08-05 18:14 ` Pedro Alves
2020-08-10 19:15 ` Tom Tromey [this message]
2020-08-10 19:25 ` Simon Marchi
2020-08-12 12:52 ` Tom Tromey
2020-08-12 15:17 ` Tom Tromey
2020-08-06 20:27 ` [PATCH 0/4] Regcache fix and optimization Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8nijos1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Laurent.Morichetti@amd.com \
--cc=Morichetti@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox