From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Use string_file::release in some places
Date: Tue, 26 Sep 2023 06:59:20 -0600 [thread overview]
Message-ID: <87o7hp5bvb.fsf@tromey.com> (raw)
In-Reply-To: <CAO90_uvJhXRGzJTKuOSzxW_qY5S35-HuP9Tfap4yZxZ-OVBiKA@mail.gmail.com> (Keith Seitz's message of "Fri, 22 Sep 2023 13:42:22 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Would symtab.c's symbol_to_info_string and valops.c:incomplete_type_hint
Keith> also qualify for similar treatment? They use addition assignment, so maybe
Keith> that alters the analogy?
These two could accumulate all the text into a single string_file.
Maybe that would be slightly better.
Anyway I'm checking this in.
Tom
prev parent reply other threads:[~2023-09-26 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 19:42 Tom Tromey via Gdb-patches
2023-09-22 20:42 ` Keith Seitz via Gdb-patches
2023-09-25 9:40 ` Lancelot SIX via Gdb-patches
2023-09-26 12:59 ` Tom Tromey via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7hp5bvb.fsf@tromey.com \
--to=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox