From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id b58tAcLVEmXFcx0AWB0awg (envelope-from ) for ; Tue, 26 Sep 2023 08:59:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=mo1FQsId; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EADD01E0C3; Tue, 26 Sep 2023 08:59:45 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFB571E092 for ; Tue, 26 Sep 2023 08:59:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE37D385C6E9 for ; Tue, 26 Sep 2023 12:59:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE37D385C6E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695733182; bh=wAtab45PZP9X4Mjn4mSg3XpM6phpUbfV7xAffwppnAk=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=mo1FQsIdhr8DHIws9mTXoJ1ywvS3x2tgkhNh+crqeH9WJT/PMjxfiCePwzCApZShF xJjCXHqjYGaKqmn/FTUDdNUovxhmndk0HfkHswy7x72e+koopCOiXjIWbzn3KjQ9a3 ik5dBRU7/M4YQun9heI7ywhK8L/wZvVQ5uo4FVDg= Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id B1F383858D35 for ; Tue, 26 Sep 2023 12:59:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1F383858D35 Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-3512f905f6cso17393705ab.3 for ; Tue, 26 Sep 2023 05:59:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695733162; x=1696337962; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wAtab45PZP9X4Mjn4mSg3XpM6phpUbfV7xAffwppnAk=; b=Xz1aeQFFCTr8G37Z/XZG1DqqndzL07qqRs/7dJXQGc3Sm+jlElEzw2f/O5WR2yiw6/ zJAOwduYLTu8WffD6pCmDQf3sCNbPm4KCwj1kDcE60KiutI+OKwORQNgOKbJjkA4hw5n oMPKCQrBTJEjmVJTlT/b4JXB6ZVNVWs6nrmHGSGDP7MBBB5Faod+Usjqw+4jD1jIqfJ2 Hp8dqkphXCdZZ8//FzYR9yll/bgWwCU/nGAOlOBMn7t7J0fShYwwx3ylgCI6eUU7EU65 YvGOCRnn9m/cwKTTdfRGuOPMhTraony2CHYtjhn7B3GQEYIgSXBLvLe3FaFab6aMLAjm uAfw== X-Gm-Message-State: AOJu0YyhWTsNDfc3MkKn7zGMlCRX11kf6DRqkYiB5hDmZPfxHdAt2E37 ZZiYFnAw6A588u0ZvauJTxUurg== X-Google-Smtp-Source: AGHT+IH8NRMFNA9h7EdLdPTwwNvLzkKzF4dMdXYTLX3OinvR3vBPY8aIIhp9P9LI18K9R1sG8SE3aA== X-Received: by 2002:a05:6e02:c2b:b0:34f:f2d3:ea70 with SMTP id q11-20020a056e020c2b00b0034ff2d3ea70mr11677866ilg.6.1695733161878; Tue, 26 Sep 2023 05:59:21 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id y3-20020a056e02128300b00351396276bcsm1573294ilq.40.2023.09.26.05.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 05:59:21 -0700 (PDT) To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Use string_file::release in some places References: <20230921194207.2401885-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 26 Sep 2023 06:59:20 -0600 In-Reply-To: (Keith Seitz's message of "Fri, 22 Sep 2023 13:42:22 -0700") Message-ID: <87o7hp5bvb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom Tromey via Gdb-patches Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Keith" == Keith Seitz writes: Keith> Would symtab.c's symbol_to_info_string and valops.c:incomplete_type_hint Keith> also qualify for similar treatment? They use addition assignment, so maybe Keith> that alters the analogy? These two could accumulate all the text into a single string_file. Maybe that would be slightly better. Anyway I'm checking this in. Tom