Re: [PATCH] [gdb] Simplify frame_follow_static_link

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> diff --git a/gdb/frame.c b/gdb/frame.c
Tom> index 7a83f5e61c0..61d37316c6a 100644
Tom> --- a/gdb/frame.c
Tom> +++ b/gdb/frame.c
Tom> @@ -3241,8 +3241,6 @@ frame_follow_static_link (const frame_info_ptr &initial_frame)
Tom>    if (frame_block == nullptr)
Tom>      return {};
 
Tom> -  frame_block = frame_block->function_block ();
Tom> -
Tom>    const struct dynamic_prop *static_link = frame_block->static_link ();
Tom>    if (static_link == nullptr)
Tom>      return {};

There's nothing wrong with this patch, but I have a patch in development
that extends frame_follow_static_link and that will need the function
block at this point.

Lowering this call into the block method will end up making things
slightly less efficient.  So I'd prefer this not go in, as I'll end up
at least having to essentially undo this hunk.

Maybe a different approach would be to change block::static_link to
document that this is only valid for function-having blocks and add an
assert to that effect in the implementation.

thanks,
Tom