From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AQa3C4tH6mlp9zYAWB0awg (envelope-from ) for ; Thu, 23 Apr 2026 12:23:39 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=RMGxTXad; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2B26A1E0BA; Thu, 23 Apr 2026 12:23:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7CC1D1E093 for ; Thu, 23 Apr 2026 12:23:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id EB6864BB1C0F for ; Thu, 23 Apr 2026 16:23:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB6864BB1C0F Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=RMGxTXad Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id A20BD4B99F77 for ; Thu, 23 Apr 2026 16:23:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A20BD4B99F77 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A20BD4B99F77 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776961392; cv=none; b=QzHec3jPzdcYqKWAOkCxgTMyCaWaAKsPd7klZ6p9ByN7ljRM5xPXXwzWI5i+1TiqGkgG7n19DuIrmJOoMH+5IBDZwJ8hY4mrjOKlvhmA4AhJOAIaEvKJeA4oEucxHu6fW4kSFr/N73dsmoxarRkBt//XsDddSUvp64fRKC9aW8k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776961392; c=relaxed/simple; bh=yHJUBJcvI/09ZyAHpwZkyerUdCIy27nYDnuZD16/SPE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LEuFZwypfQ+/T2dhIpvay8ssqEOmuQjNj2l7piigw+hGiX/qp8NhZM6yvEeE66JjKhdBhGWSN6SbER8edexQS59udJ0WPd3oRFOhT3PLe/RofyY/CnnuCZvFRo2AZ5npExQuVS6kdcm8MT6WP3wyh/p/lZdMJzpRmoP7FIRLE7Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A20BD4B99F77 Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id Ftf1wVgXD4RkpFwpbwg8ax; Thu, 23 Apr 2026 16:23:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id FwpawaUA9YO6jFwpbwbgiU; Thu, 23 Apr 2026 16:23:11 +0000 X-Authority-Analysis: v=2.4 cv=ffyty1QF c=1 sm=1 tr=0 ts=69ea476f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=edZHlPnRgGUG0kAQ3OkA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hp3i+I7y/b4x05/91bG4ri+SU7jeFoe1qGAh26JdZGw=; b=RMGxTXadaRMMcyUra3b0RRtEN3 6yXK6L4x1WEv0aoFkQ+D7flrMCVNZFACDwrzEu9Fe/aBfjB2XmFvgCGuZ2/4HLUvWLaRyribnB70B KBTRHYhIQyTWv90DoCIn2NmAb; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:48084 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wFwpa-000000037R9-2Sal; Thu, 23 Apr 2026 10:23:10 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb] Simplify frame_follow_static_link In-Reply-To: <20260421122139.243506-1-tdevries@suse.de> (Tom de Vries's message of "Tue, 21 Apr 2026 14:21:39 +0200") References: <20260421122139.243506-1-tdevries@suse.de> X-Attribution: Tom Date: Thu, 23 Apr 2026 10:23:09 -0600 Message-ID: <87o6j9prwy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wFwpa-000000037R9-2Sal X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:48084 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOYyMztEz9ewpDbduRmpLWGV7je/77mz0CL1zxnPlJbPPNYVTif1/1o2uyu5/CFx7g0mqyfjki6gT5gs44462x1uKwFyP32jFWLipLSTqvi7TyiT8Rai +cAuXaDPVIVkflUzJhhLQJpPv1cPsfVk8wzwCNa/R+vH2OFaPVgYhkP0V1yTTFU20+h78XVh8rClN4aXQ+oaXSRl2nwbMeN4lqU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> diff --git a/gdb/frame.c b/gdb/frame.c Tom> index 7a83f5e61c0..61d37316c6a 100644 Tom> --- a/gdb/frame.c Tom> +++ b/gdb/frame.c Tom> @@ -3241,8 +3241,6 @@ frame_follow_static_link (const frame_info_ptr &initial_frame) Tom> if (frame_block == nullptr) Tom> return {}; Tom> - frame_block = frame_block->function_block (); Tom> - Tom> const struct dynamic_prop *static_link = frame_block->static_link (); Tom> if (static_link == nullptr) Tom> return {}; There's nothing wrong with this patch, but I have a patch in development that extends frame_follow_static_link and that will need the function block at this point. Lowering this call into the block method will end up making things slightly less efficient. So I'd prefer this not go in, as I'll end up at least having to essentially undo this hunk. Maybe a different approach would be to change block::static_link to document that this is only valid for function-having blocks and add an assert to that effect in the implementation. thanks, Tom