Re: [PATCH] Use Solaris iconv

[Tom Tromey <tom@tromey.com>]

>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

Rainer> However, Solaris 11.4 iconv is good enough to use: enabling its use
Rainer> fixes 300+ failures.

Rainer> Ok for trunk?

I think it's fine, but my question here is whether gdb intends to
support versions of Solaris where this might not work.

Rainer> -   Finally, some systems do not have iconv, or are really broken
Rainer> -   (e.g., Solaris, which almost has all of this working, but where
Rainer> -   just enough is broken to make it too hard to use).  Here we provide
Rainer> -   a phony iconv which only handles a single character set, and we

Ages ago I wrote this text, and it was true at the time.  IIRC, Solaris
back then used some undocumented, idiosyncratic, system-specific wchar_t
encoding and there was no way to convert from the regular encodings to
wchar_t via iconv, or something like that.

I don't know when Solaris changed to using Unicode.

Anyway I guess the question I have is whether this:

Rainer> -      || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108))
Rainer> +      || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108) \
Rainer> +      || (defined (__sun__) && defined (__svr4__)))
 
... should check some kind of Solaris version.

If not, maybe adding some note to the commit message on this topic would
be nice to have.

thanks,
Tom