From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QPtLCowsh2oojjIAWB0awg (envelope-from ) for ; Thu, 20 Aug 2026 12:34:20 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=c3JrYYnZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0F1A71E0A3; Thu, 20 Aug 2026 12:34:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 12F8B1E033 for ; Thu, 20 Aug 2026 12:34:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 376104BB1C1C for ; Thu, 20 Aug 2026 16:34:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 376104BB1C1C Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=c3JrYYnZ Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 1E36F4B9DB6E for ; Thu, 20 Aug 2026 16:33:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E36F4B9DB6E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E36F4B9DB6E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787243608; cv=none; b=KWOp2DmX/6b20Ylt1XqdCX2EBQQiCkZZm+N26jxj5ghITqtFN1rg/Dk1cQTYDLIuMeEKYMMc7BpAzwzmJAaiUZP4V3HcotItqAvZhH/No25WUBja7VcBeCexIJ6zxuswSe13BXrry15EpUnnDi8FmM0xnTEGpKdA8i08jTUUnxY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787243608; c=relaxed/simple; bh=UhpbOLpEC/KxAovNzpYOfyzPk0LNiCPPH7efut8btkI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=scZnsUPZG7UEcwRHI6vSjfXngtGUay0gJQcly74Ub/u/CIyDiTaXZzinjsNWLqWJEfZZgkC16zpd8p1jYgAAI3xXrkZ+CL6rBYPtEDTL/1rrasNte4nBjYfvGAozcJsgwINX2Z+bQdNtpFscBIt0eufEiZrd1rpyvsTeDlr6IUQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=c3JrYYnZ reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E36F4B9DB6E Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id x2tAweOnKLvgbx5hmw05XW; Thu, 20 Aug 2026 16:33:26 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id x5hlwh9KXLQlXx5hmwkirO; Thu, 20 Aug 2026 16:33:26 +0000 X-Authority-Analysis: v=2.4 cv=AeWxH2XG c=1 sm=1 tr=0 ts=6a872c56 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=gnS_2FMIqo4VV042ercA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=P8evkS4iZRtZ92t/bmexssFIAw0a/NVwxW3MutGoVc0=; b=c3JrYYnZcHsx3fLNcTAgfGliLX nmPZinvHTBmSCfXhftNoISiul/y710LeA7C8vPawl4UtUaV9W2/Vp50GdwTTUQqDR97ADFdsT3ao9 g0q8GzTgGuyZGqZUliWQPFYLB; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:40284 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wx5hl-00000002gOn-16Ox; Thu, 20 Aug 2026 10:33:25 -0600 From: Tom Tromey To: Rainer Orth Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use Solaris iconv In-Reply-To: (Rainer Orth's message of "Wed, 19 Aug 2026 14:23:57 +0200") References: X-Attribution: Tom Date: Thu, 20 Aug 2026 10:33:24 -0600 Message-ID: <87o6ewu4yz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wx5hl-00000002gOn-16Ox X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:40284 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNjxTDYVrJLJtRo6RiQyGeVVBAx6bc5cayxELhHO6H3nlVMdMp3BWLPfkyUSV6qfHXtXKSMdyLg4++MZvUC0QA589aKKmDAHLUZQdZn+HTS6SAXnfOq4 l2n0QiPuxGZ+gNskLRejIZ+LzFsNqsrhGUxMmUNLWIxdp1G/Lrrngayx40nO5QXjV4E57Y6VC1h6Bfgg4VW5VGV+dngLUksUmzY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Rainer" == Rainer Orth writes: Rainer> However, Solaris 11.4 iconv is good enough to use: enabling its use Rainer> fixes 300+ failures. Rainer> Ok for trunk? I think it's fine, but my question here is whether gdb intends to support versions of Solaris where this might not work. Rainer> - Finally, some systems do not have iconv, or are really broken Rainer> - (e.g., Solaris, which almost has all of this working, but where Rainer> - just enough is broken to make it too hard to use). Here we provide Rainer> - a phony iconv which only handles a single character set, and we Ages ago I wrote this text, and it was true at the time. IIRC, Solaris back then used some undocumented, idiosyncratic, system-specific wchar_t encoding and there was no way to convert from the regular encodings to wchar_t via iconv, or something like that. I don't know when Solaris changed to using Unicode. Anyway I guess the question I have is whether this: Rainer> - || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108)) Rainer> + || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108) \ Rainer> + || (defined (__sun__) && defined (__svr4__))) ... should check some kind of Solaris version. If not, maybe adding some note to the commit message on this topic would be nice to have. thanks, Tom