From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] find_partial_die cleanups
Date: Mon, 09 Apr 2012 18:16:00 -0000 [thread overview]
Message-ID: <87mx6k93f4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120409174612.1F60824618E@ruffy.mtv.corp.google.com> (Doug Evans's message of "Mon, 9 Apr 2012 10:46:12 -0700 (PDT)")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> but I want to check in some preliminary changes so that there's a
Doug> better base to review the patches from, plus make some general
Doug> improvements along the way.
Sounds great.
Doug> This patch is standalone, and so I'm not submitting it as part of a set.
Doug> I will check this in in a few days if there are no objections.
No objections here, just a question and a nit.
Doug> + error (_("Dwarf Error: Type Unit at offset 0x%lx contains"
Doug> + " external reference to offset 0x%lx [in module %s].\n"),
Doug> + (long) cu->header.offset.sect_off, (long) offset.sect_off,
Doug> + bfd_get_filename (objfile->obfd));
Why an error and not a complaint?
I ask because errors have a pretty drastic effect on debuginfo reading.
Doug> + struct dwarf2_section_info* sec;
Wrong "*" placement.
Tom
next prev parent reply other threads:[~2012-04-09 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 17:46 Doug Evans
2012-04-09 18:16 ` Tom Tromey [this message]
2012-04-09 18:26 ` Doug Evans
2012-04-09 18:48 ` Tom Tromey
2012-04-10 19:19 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx6k93f4.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox