From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16723 invoked by alias); 9 Apr 2012 18:16:47 -0000 Received: (qmail 16711 invoked by uid 22791); 9 Apr 2012 18:16:46 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Apr 2012 18:16:19 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q39IGH8W031668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 9 Apr 2012 14:16:17 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q39IGGW4026847 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 9 Apr 2012 14:16:16 -0400 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [patch] find_partial_die cleanups References: <20120409174612.1F60824618E@ruffy.mtv.corp.google.com> Date: Mon, 09 Apr 2012 18:16:00 -0000 In-Reply-To: <20120409174612.1F60824618E@ruffy.mtv.corp.google.com> (Doug Evans's message of "Mon, 9 Apr 2012 10:46:12 -0700 (PDT)") Message-ID: <87mx6k93f4.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00157.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> but I want to check in some preliminary changes so that there's a Doug> better base to review the patches from, plus make some general Doug> improvements along the way. Sounds great. Doug> This patch is standalone, and so I'm not submitting it as part of a set. Doug> I will check this in in a few days if there are no objections. No objections here, just a question and a nit. Doug> + error (_("Dwarf Error: Type Unit at offset 0x%lx contains" Doug> + " external reference to offset 0x%lx [in module %s].\n"), Doug> + (long) cu->header.offset.sect_off, (long) offset.sect_off, Doug> + bfd_get_filename (objfile->obfd)); Why an error and not a complaint? I ask because errors have a pretty drastic effect on debuginfo reading. Doug> + struct dwarf2_section_info* sec; Wrong "*" placement. Tom