Re: [PATCH v3] Add more methods to gdb.Progspace

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> LGTM, I just noted some minor comments.
Simon> I wish there was more consistency in how the methods are documented (in the
Simon> progspace_object_methods array), but that should be another patch.

Send more details and let's agree on some kind of standard here.
I think these doc strings are mostly an afterthought at the moment, but
there's no reason they should be.

>> +@code{current_progspace().find_pc_line(pc)} and is included for

Simon> Perhaps this should say gdb.current_progspace().find_pc_line(pc) ?

I made this change (3 spots).

>> +  else
>> +    {
>> +      str_obj = Py_None;
>> +      Py_INCREF (Py_None);
>> +    }

Simon> I know this is pre-existing code, but it could use Py_RETURN_NONE, then
Simon> we can get rid of the str_obj variable.

I made this change.

I'll check this in momentarily.  Thank you for the review.

Tom