From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85034 invoked by alias); 16 Sep 2018 12:49:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82659 invoked by uid 89); 16 Sep 2018 12:48:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=Hx-languages-length:946 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.187.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Sep 2018 12:48:24 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway36.websitewelcome.com (Postfix) with ESMTP id E6DED400C5D90 for ; Sun, 16 Sep 2018 06:53:31 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1WT7gMO3DbXuJ1WTFgefis; Sun, 16 Sep 2018 07:48:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=l9tNYmLhiDQDQRxKlIsMtOw8csdLYVJ6bdQhMOIgkTI=; b=czfZdFvl0qyMcG5s/kOlm42VEZ tAtpcS225AtvVuFrSYeBOnq5vCfZia/fxXuGxSJA3/zby73vSoc7WFnNK3qkXn0OxWeqFMY3Yzuvi T/pjDon4IACPU1JgCYguWcNx1; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:46170 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1WT7-0042hi-5x; Sun, 16 Sep 2018 07:48:05 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v3] Add more methods to gdb.Progspace References: <20180913221627.13772-1-tom@tromey.com> Date: Sun, 16 Sep 2018 12:49:00 -0000 In-Reply-To: (Simon Marchi's message of "Sat, 15 Sep 2018 23:09:57 -0400") Message-ID: <87mushpq0r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00535.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> LGTM, I just noted some minor comments. Simon> I wish there was more consistency in how the methods are documented (in the Simon> progspace_object_methods array), but that should be another patch. Send more details and let's agree on some kind of standard here. I think these doc strings are mostly an afterthought at the moment, but there's no reason they should be. >> +@code{current_progspace().find_pc_line(pc)} and is included for Simon> Perhaps this should say gdb.current_progspace().find_pc_line(pc) ? I made this change (3 spots). >> + else >> + { >> + str_obj = Py_None; >> + Py_INCREF (Py_None); >> + } Simon> I know this is pre-existing code, but it could use Py_RETURN_NONE, then Simon> we can get rid of the str_obj variable. I made this change. I'll check this in momentarily. Thank you for the review. Tom