From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR gdb/23835: Don't redefine _FORTIFY_SOURCE if it's already defined
Date: Wed, 31 Oct 2018 21:43:00 -0000 [thread overview]
Message-ID: <87muqt94hv.fsf@redhat.com> (raw)
In-Reply-To: <20181031212700.GC4081@adacore.com> (Joel Brobecker's message of "Wed, 31 Oct 2018 14:27:00 -0700")
On Wednesday, October 31 2018, Joel Brobecker wrote:
>> Thanks for the review, Joel.
>>
>> Given that two global maintainers replied and approved the patch, I
>> assume it's OK if I go ahead and push it...?
>
> Yes, sorry. That was part of the intent of my message; it's
> a small patch anyway, so if we find there are problems with it,
> or objections we can't resolve quickly, it's easy to revert.
Thanks, Joel. I pushed the patch now.
656efb5e2691b2bd29573d9985d20206c47b6927
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2018-10-31 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 21:42 Sergio Durigan Junior
2018-10-30 21:54 ` Simon Marchi
2018-10-30 22:47 ` Joel Brobecker
2018-10-31 20:05 ` Sergio Durigan Junior
2018-10-31 21:27 ` Joel Brobecker
2018-10-31 21:43 ` Sergio Durigan Junior [this message]
2018-10-31 20:04 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muqt94hv.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox