From: Tom Tromey <tom@tromey.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Avoid crash when calling warning too early
Date: Thu, 08 Nov 2018 23:10:00 -0000 [thread overview]
Message-ID: <87muqjupwx.fsf@tromey.com> (raw)
In-Reply-To: <87r2g597kb.fsf@redhat.com> (Sergio Durigan Junior's message of "Wed, 31 Oct 2018 16:37:08 -0400")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>> If you want, I can just drop this and you can take over.
Sergio> Thanks, but I'd prefer if you checked your patch in. The bug reported
Sergio> on 23555 is actually composed of two issues: (a) what to do when GDB
Sergio> can't determine the CWD, and (b) the segmentation fault that happens
Sergio> when we try to call warning too early in the code. Your patch fixes
Sergio> (b), and I still didn't sit down to figure out how to approach (a). So
Sergio> it's best if we just go ahead and avoid the segfault for now.
I'm going to check it in now, with the ChangeLog change you suggested.
Tom
next prev parent reply other threads:[~2018-11-08 23:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 18:18 Tom Tromey
2018-10-31 18:44 ` Sergio Durigan Junior
2018-10-31 20:27 ` Tom Tromey
2018-10-31 20:37 ` Sergio Durigan Junior
2018-11-08 23:10 ` Tom Tromey [this message]
2018-11-09 19:41 ` Pedro Alves
2018-11-15 23:22 ` Tom Tromey
2018-11-16 13:31 ` Pedro Alves
2018-11-18 18:46 ` Tom Tromey
2018-11-19 15:27 ` Pedro Alves
2018-11-15 23:25 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muqjupwx.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox