From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89664 invoked by alias); 8 Nov 2018 23:10:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89636 invoked by uid 89); 8 Nov 2018 23:10:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=composed, sergio, Sergio, durigan X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.38) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Nov 2018 23:10:09 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id BECF9489A for ; Thu, 8 Nov 2018 17:10:07 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KtR9gPj2gaSeyKtR9gfxYF; Thu, 08 Nov 2018 17:10:07 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fQqk4OGuFdNBMa+WfW+r64iAhTfh98Ua0ehU8wlabjM=; b=ETxQ1HjfArWc9Jtr1Zn8yF4ZMe JCSsloYxr/gsQFsCwNSWyDhq3h1NyZ1NSsQbu/vdKtFAS9T/2pb1fyOJ7jCOuiwuGQZpo7u9yRMY5 utiNVZfdIknRfV+F2hyivH7Rv; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:55078 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gKtR9-003aFn-E5; Thu, 08 Nov 2018 17:10:07 -0600 From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Avoid crash when calling warning too early References: <20181031181820.24308-1-tom@tromey.com> <875zxi9csd.fsf@redhat.com> <87y3adn9o8.fsf@tromey.com> <87r2g597kb.fsf@redhat.com> Date: Thu, 08 Nov 2018 23:10:00 -0000 In-Reply-To: <87r2g597kb.fsf@redhat.com> (Sergio Durigan Junior's message of "Wed, 31 Oct 2018 16:37:08 -0400") Message-ID: <87muqjupwx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00134.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: >> If you want, I can just drop this and you can take over. Sergio> Thanks, but I'd prefer if you checked your patch in. The bug reported Sergio> on 23555 is actually composed of two issues: (a) what to do when GDB Sergio> can't determine the CWD, and (b) the segmentation fault that happens Sergio> when we try to call warning too early in the code. Your patch fixes Sergio> (b), and I still didn't sit down to figure out how to approach (a). So Sergio> it's best if we just go ahead and avoid the segfault for now. I'm going to check it in now, with the ChangeLog change you suggested. Tom