Re: [PATCH] Use less horizontal space in source window

[Tom Tromey <tom@tromey.com>]

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I tried this out a bit, and IMHO the experience is worse than before, given
Pedro> the left/right shifting when stepping as you move between source files.

Thanks for giving it a try.

BTW, normally I remember to push branches to github, so it's often easy
to try them by fetching and checking out the appropriate branch.  At
least, I find this simpler than applying patches from email.

Pedro> I'd probably be fine with reducing the width if we still had a reasonable
Pedro> minimum that is enough to fit reasonably-sized source files.  I think that
Pedro> if we change this, we should also have more than one space between the line
Pedro> number and the source though.  One single space as in your patch makes it harder
Pedro> to distinguish between what is a line and the source IMO.  More so with
Pedro> styling disabled.

Good points.  And about the styling -- I try never to have it off any
more, so I didn't notice that.

Pedro> I have to say that I find it a bit odd to be optimizing the horizontal space,
Pedro> since the sources I debug (gdb!) mostly wrap around 80 cols, and my terminal
Pedro> is usually much larger than that, so I always have tons of empty space
Pedro> on the right side of the source window.

I often (but not always) have an 80 column terminal, so when I have
debugged gdb, it's still made a bit of difference sometimes.

Tom