From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18962 invoked by alias); 20 Aug 2019 22:28:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18757 invoked by uid 89); 20 Aug 2019 22:28:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Aug 2019 22:28:58 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway32.websitewelcome.com (Postfix) with ESMTP id ABBA1270D87 for ; Tue, 20 Aug 2019 17:25:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0CZbirlt290on0CZbifDfZ; Tue, 20 Aug 2019 17:25:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zO6baFjwLVZpeAL5faAMS8s8zbgOfnFZZ+lUY5F/sOs=; b=yS+qaFqsTGu6ZQor6BRFmQOq0x 1iU88vjY6UzMSoy5UnV/9v/Pbd2zZ6ERITMXok5wbv2zljMca/VtMms3rK2gmv2R84SUlPYtHTI7t T/f2olZdnEhpEhpDMIGT3W5G4; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:43840 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i0CZb-000GYh-CY; Tue, 20 Aug 2019 17:25:51 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Use less horizontal space in source window References: <20190816023631.26830-1-tom@tromey.com> Date: Tue, 20 Aug 2019 22:28:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 16 Aug 2019 14:55:09 +0100") Message-ID: <87mug3iidt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00441.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I tried this out a bit, and IMHO the experience is worse than before, given Pedro> the left/right shifting when stepping as you move between source files. Thanks for giving it a try. BTW, normally I remember to push branches to github, so it's often easy to try them by fetching and checking out the appropriate branch. At least, I find this simpler than applying patches from email. Pedro> I'd probably be fine with reducing the width if we still had a reasonable Pedro> minimum that is enough to fit reasonably-sized source files. I think that Pedro> if we change this, we should also have more than one space between the line Pedro> number and the source though. One single space as in your patch makes it harder Pedro> to distinguish between what is a line and the source IMO. More so with Pedro> styling disabled. Good points. And about the styling -- I try never to have it off any more, so I didn't notice that. Pedro> I have to say that I find it a bit odd to be optimizing the horizontal space, Pedro> since the sources I debug (gdb!) mostly wrap around 80 cols, and my terminal Pedro> is usually much larger than that, so I always have tons of empty space Pedro> on the right side of the source window. I often (but not always) have an 80 column terminal, so when I have debugged gdb, it's still made a bit of difference sometimes. Tom