From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Fix partial unit psymtabs
Date: Thu, 12 Mar 2020 13:06:03 -0600 [thread overview]
Message-ID: <87mu8lieas.fsf@tromey.com> (raw)
In-Reply-To: <20200310172723.GA4755@delia> (Tom de Vries's message of "Tue, 10 Mar 2020 18:27:24 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> This is an artefact resulting from the fact that all CUs in an objfile
Tom> share the same storage array for static partial symbols (and another array for
Tom> global partial symbols), using a range to describe their symbols.
Wow, nice catch. This bug has been there since imported CUs were
implemented.
Tom> + /* Stack of vectors of partial symbols, using during psymtab
Tom> + initialization. */
Tom> +
Tom> + std::vector<std::vector<partial_symbol *>*> current_global_psymbols;
Tom> + std::vector<std::vector<partial_symbol *>*> current_static_psymbols;
I mildly don't like putting this here. Ideally it would be handled
purely in the DWARF reader. However, I see this as a side effect of the
way that psymtabs are currently managed ("poorly"). I have some patches
that change this, and I suppose this could be modified on that branch.
Meanwhile, this patch is ok. Thank you for find this and for this fix.
Tom
prev parent reply other threads:[~2020-03-12 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 17:27 Tom de Vries
2020-03-12 19:06 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu8lieas.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox