From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.107]) by sourceware.org (Postfix) with ESMTPS id 01C11387700F for ; Thu, 12 Mar 2020 19:06:05 +0000 (GMT) Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 715AE13532 for ; Thu, 12 Mar 2020 14:06:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CT9gjiE1kRP4zCT9gj4AEw; Thu, 12 Mar 2020 14:06:04 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Ctd2Az9EFjH2Hk0+xRttmrc+MkkX6BDZUM+DtXmWR0=; b=WsRomntiMpKDIeYZp/ga1iEIL9 hsBZaeeNXJ5qf1gyXmyllNFKYpfJNBG66EHdnIyd0OYq+PVZjfg2KebjVxpL4gRWIJ3ffdrA4Q7pj WyS+v047qJMg5MMFUNg/ixY10; Received: from 184-96-250-69.hlrn.qwest.net ([184.96.250.69]:60942 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jCT9g-0027Jp-4B; Thu, 12 Mar 2020 13:06:04 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/symtab] Fix partial unit psymtabs References: <20200310172723.GA4755@delia> X-Attribution: Tom Date: Thu, 12 Mar 2020 13:06:03 -0600 In-Reply-To: <20200310172723.GA4755@delia> (Tom de Vries's message of "Tue, 10 Mar 2020 18:27:24 +0100") Message-ID: <87mu8lieas.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.250.69 X-Source-L: No X-Exim-ID: 1jCT9g-0027Jp-4B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-250-69.hlrn.qwest.net (murgatroyd) [184.96.250.69]:60942 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 19:06:07 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> This is an artefact resulting from the fact that all CUs in an objfile Tom> share the same storage array for static partial symbols (and another array for Tom> global partial symbols), using a range to describe their symbols. Wow, nice catch. This bug has been there since imported CUs were implemented. Tom> + /* Stack of vectors of partial symbols, using during psymtab Tom> + initialization. */ Tom> + Tom> + std::vector*> current_global_psymbols; Tom> + std::vector*> current_static_psymbols; I mildly don't like putting this here. Ideally it would be handled purely in the DWARF reader. However, I see this as a side effect of the way that psymtabs are currently managed ("poorly"). I have some patches that change this, and I suppose this could be modified on that branch. Meanwhile, this patch is ok. Thank you for find this and for this fix. Tom