From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Use CORE_ADDR as return type from x86_dr_low_get_addr
Date: Fri, 03 Sep 2021 10:48:23 -0600 [thread overview]
Message-ID: <87mtotli5k.fsf@tromey.com> (raw)
In-Reply-To: <f4b51e09-4830-d5fd-54b8-8bcfb3b96239@polymtl.ca> (Simon Marchi's message of "Fri, 3 Sep 2021 12:43:10 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>> -static uintptr_t dr[8];
>> +static CORE_ADDR dr[8];
Simon> I don't really mind the change, but I don't know if that's really any
Simon> more clear, because not all DR registers contain addresses, which is
Simon> what using CORE_ADDR suggests. I guess the point of using uintptr_t is
Simon> that they are 32 bits when GDB is built as 32-bit (and it can't debug
Simon> 64-bit programs then) and 64 bits when GDB is built as 64-bit (and the
Simon> top 32 bits are unused when debugging a 32-bit program). What prompted
Simon> you to change this part?
It just seemed to me that, most of the time, the value really is a
CORE_ADDR, and that anyway a CORE_ADDR would definitely be large enough.
Tom
next prev parent reply other threads:[~2021-09-03 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 16:32 Tom Tromey
2021-09-03 16:43 ` Simon Marchi via Gdb-patches
2021-09-03 16:48 ` Tom Tromey [this message]
2021-09-03 17:00 ` Tom Tromey
2021-09-03 17:17 ` Simon Marchi via Gdb-patches
2021-09-03 17:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtotli5k.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox