From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9dOxBuRRMmERFAAAWB0awg (envelope-from ) for ; Fri, 03 Sep 2021 12:48:36 -0400 Received: by simark.ca (Postfix, from userid 112) id 04FC41EE22; Fri, 3 Sep 2021 12:48:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 396821EDDB for ; Fri, 3 Sep 2021 12:48:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9BDD384780F for ; Fri, 3 Sep 2021 16:48:34 +0000 (GMT) Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id E507D384B13A for ; Fri, 3 Sep 2021 16:48:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E507D384B13A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd36.google.com with SMTP id y18so7546332ioc.1 for ; Fri, 03 Sep 2021 09:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rh91SJcV0ZKNjNAzjoFsE67tQb8VEQwF708XP1QSXcw=; b=gxMCewuXc+zk1BTe4NeGQb95GhVFRRtpbgDdd2Ygp+oaUlHrJQPi/HQnSZPG4ZVDh1 hHS3qHfVWZox2Xc7aD5OY1NZzXyAsKFz+r4aeE5gUPrNFBFu4cnIx4WAfIOWWJra/qnr b0vMyQ9f4KqlskrBs6kgZfALf1K3u7HF5bPT/lgPU8BQPlTAgqKjBReU0D83hvowxEgI RgW72SqVIjBTF6cZfYtEkLTmc0aMu900z0UvBvimadNYYpaN0mPV6Why9+khjoNpYTgF 4lWzipG5n0ManWAicWUv+WSDN0kGtxxP6wbalYL5tXvpo//2zwQmgCDRGGzbkWV3Cnu6 oyQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rh91SJcV0ZKNjNAzjoFsE67tQb8VEQwF708XP1QSXcw=; b=p3c/X096/UjGLFpI5771nGUfoQJ9pQtXS+/B2up1jq9ih+ervPaN27LXcZu4bsHSxw FshhszWyrlZadkPAzEXnwuDsrzvsO+mOSHNQYXc8f9/OCCvKonadyyE6OhqVCvtE+3nI pUnFhRMLAGIskocbRY0kFWB6YOO/YsDK4FfI2uQ6lZGSPoNbhTuad0PQtEb7b93DlQwJ PvOTpVDVV8/zVpkrDgJz1SVEfR/DLecZOeUtqsqQzywYWYiBYg63uDwUAQYgtk2ZVEr4 38fJ1fhP97E7zppP5d6gQh793BSzHTpez+hH9pNW2vjIkpCJ6ajuuwn1SBnO0DANYogX KR4w== X-Gm-Message-State: AOAM530dgqgxzwplMI/Rbw36g3ksX79rXvGVnHPuEDt2LoptX1Hr8+wi h3lDY+sgxlp+X1s6IiUHhk630Q== X-Google-Smtp-Source: ABdhPJyyLqn6gpRdvCpTNMJo2m86OfxfzlzNBVd43p0U0U8rx3+7ePEfyBRFYpB4l1CmJz3CdGHDqw== X-Received: by 2002:a05:6638:1646:: with SMTP id a6mr3373970jat.27.1630687704338; Fri, 03 Sep 2021 09:48:24 -0700 (PDT) Received: from murgatroyd (97-122-72-212.hlrn.qwest.net. [97.122.72.212]) by smtp.gmail.com with ESMTPSA id o2sm2879159ilg.47.2021.09.03.09.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 09:48:23 -0700 (PDT) From: Tom Tromey To: Simon Marchi Subject: Re: [PATCH] Use CORE_ADDR as return type from x86_dr_low_get_addr References: <20210903163219.2590419-1-tromey@adacore.com> X-Attribution: Tom Date: Fri, 03 Sep 2021 10:48:23 -0600 In-Reply-To: (Simon Marchi's message of "Fri, 3 Sep 2021 12:43:10 -0400") Message-ID: <87mtotli5k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org, Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi writes: >> -static uintptr_t dr[8]; >> +static CORE_ADDR dr[8]; Simon> I don't really mind the change, but I don't know if that's really any Simon> more clear, because not all DR registers contain addresses, which is Simon> what using CORE_ADDR suggests. I guess the point of using uintptr_t is Simon> that they are 32 bits when GDB is built as 32-bit (and it can't debug Simon> 64-bit programs then) and 64 bits when GDB is built as 64-bit (and the Simon> top 32 bits are unused when debugging a 32-bit program). What prompted Simon> you to change this part? It just seemed to me that, most of the time, the value really is a CORE_ADDR, and that anyway a CORE_ADDR would definitely be large enough. Tom