Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow non-ASCII characters in Rust identifiers
Date: Sun, 03 Apr 2022 10:51:03 -0600	[thread overview]
Message-ID: <87mth26rgo.fsf@tromey.com> (raw)
In-Reply-To: <87ee2e87l6.fsf@redhat.com> (Andrew Burgess's message of "Sun, 03 Apr 2022 17:17:25 +0100")

Andrew> I'm seeing this test fail.

Andrew>  $ rustc --version
Andrew>  rustc 1.59.0 (9d1b2106e 2022-02-23)

I installed this version with "rustup toolchain install 1.59.0" and set
it to be my default.

Andrew> I've tested with gdb commit a723766c0e2 and 5187219460c.

I tried 552f1157c6262, a recent-ish git master.
It works fine for me.

Andrew> Do these pass for you?  Any suggestions for where to start looking?

I wonder if this line in the .exp isn't having the desired effect:

    setenv LC_ALL C.UTF-8

Is this happening interactively or in some kind of automation
environment?  Are the correct locales installed?  Do other
LC_ALL-setting tests fail?

Andrew>  print "ð<U+009D><U+0095>¯"
Andrew>  $1 = "ð\302\235\302\225¯"

One thing I'd suggest is checking by hand if either the 'print' line or
the '$1 = ' line has the correct byte values for the UTF-8 encoded form
of the character in question.

Tom

  reply	other threads:[~2022-04-03 16:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 23:15 Tom Tromey
2022-02-06 20:23 ` Tom Tromey
2022-04-03 16:17   ` Andrew Burgess via Gdb-patches
2022-04-03 16:51     ` Tom Tromey [this message]
2022-04-03 17:34       ` Andrew Burgess via Gdb-patches
2022-04-04  9:10         ` Andrew Burgess via Gdb-patches
2022-04-04  9:48           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mth26rgo.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox