Re: [PATCH] Allow non-ASCII characters in Rust identifiers

[Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> Rust 1.53 (quite a while ago now) ungated the support for non-ASCII
> Tom> identifiers.  This didn't work in gdb.  This is PR rust/20166.
>
> I'm checking this in.

Hi Tom!

I'm seeing this test fail.

 $ rustc --version
 rustc 1.59.0 (9d1b2106e 2022-02-23)

I've tested with gdb commit a723766c0e2 and 5187219460c.

Here's the output from gdb.log:

  (gdb) run 
  Starting program: /home/andrew/projects/binutils-gdb/build/gdb/testsuite/outputs/gdb.rust/unicode/unicode 
  [Thread debugging using libthread_db enabled]
  Using host libthread_db library "/lib64/libthread_db.so.1".
  
  Breakpoint 1, unicode::main () at /home/andrew/projects/binutils-gdb/build/gdb/testsuite/../../../src/gdb/testsuite/gdb.rust/unicode.rs:25
  25          println!("{}, {}", ð<U+009D><U+0095>¯, cç);        // set breakpoint here
  (gdb) print ð<U+009D><U+0095>¯
  unexpected token
  (gdb) FAIL: gdb.rust/unicode.exp: print D
  print "ð<U+009D><U+0095>¯"
  $1 = "ð\302\235\302\225¯"
  (gdb) FAIL: gdb.rust/unicode.exp: print D in string
  print 'ð<U+009D><U+0095>¯'
  Unterminated character literal
  (gdb) FAIL: gdb.rust/unicode.exp: print D as char
  print cç
  No symbol 'c' in current context
  (gdb) FAIL: gdb.rust/unicode.exp: print cc
  print 'çc'
  Unterminated character literal
  (gdb) FAIL: gdb.rust/unicode.exp: print cc as char

Do these pass for you?  Any suggestions for where to start looking?

Thanks,
Andrew