Re: [PATCH 1/1] gdb: use waitpid directly in wait_to_die_with_timeout

[Tom Tromey <tom@tromey.com>]

>>>>> Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:

> This is a regression since commit "[gdb] Use gdb::waitpid more often",
> before which GDB was giving the prompt after a timeout.  The reason is
> in wait_to_die_with_timeout GDB calls gdb::waitpid to wait for
> gdbserver with an interrupt timeout set by an alarm call.  In
> gdb::waitpid, we call gdb::handle_eintr, which repeatedly makes the
> syscall if it's interrupted.  In this case, however, we wouldn't want
> to repeat the waitpid if the timeout expired.  Hence, go back to using
> waitpid directly, instead of gdb::waitpid, to restore the previous
> behavior.

Makes sense.  Thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Tom