From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0VRIH2bU8GlNPgEAWB0awg (envelope-from ) for ; Tue, 28 Apr 2026 11:38:14 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Cy9qF29m; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7A20B1E0BA; Tue, 28 Apr 2026 11:38:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C00A21E067 for ; Tue, 28 Apr 2026 11:38:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D9F374BB3BF5 for ; Tue, 28 Apr 2026 15:38:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9F374BB3BF5 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Cy9qF29m Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id B420B4BABF3F for ; Tue, 28 Apr 2026 15:37:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B420B4BABF3F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B420B4BABF3F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777390667; cv=none; b=q+f7o6t3DStKlzZ51UcHesMnWxoBtWGpV88/EaTKUns8O/VIbVf+M0/asBLugVjV0rQfGDzjQTuI6y/POOaHiLBreNYn5bkNg1Oi0eLQSXVuR3mfxlwhQIamFJ8LJeTpS7NALsSBbF78FgLqmeZf1UhA+F+IGIVXMSXtqPuJQVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777390667; c=relaxed/simple; bh=BuysxWuMbI7rkWKrt6y7NkPZkhU/vRuN7c01VO3a1gk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=G7b330Abx+kyioEL5OPWYpx9OoddMV2jAb9PxXFvp1cYnoK95k93oqAmwalPdGW0RRB62scDEyhhoA59aAPEIP5QOvXnKRjTptQ48iBfTH7RvvaFBRgnWfmVW8wfyO7hYvyYvTfJJwu+yRzi/C8JfOmK18wyap+7G3Tcf6L8JOc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B420B4BABF3F Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id HioIwnJkdshqQHkVNwQcHB; Tue, 28 Apr 2026 15:37:45 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id HkVNww9GJw84vHkVNwzcTn; Tue, 28 Apr 2026 15:37:45 +0000 X-Authority-Analysis: v=2.4 cv=ZIbXmW7b c=1 sm=1 tr=0 ts=69f0d449 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=nP2ahFFrG3n0p0VZJSwA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ey67aM3IKRFW2xq/6k5EN+ryEVSXCrgAS0NHcodZemQ=; b=Cy9qF29mSsrpcnxjd4F08Un0Zt AlGD0IQ9OO3v2z7OZkQc9g0PAD66gCXoN9hWjsdSU1GD0Z6FwD6XfH8CDzCpwuU7q4ryIJs0vJyc2 KDk1Zbi+xaSx6YWzjhXWyeG1M; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:47016 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wHkVM-00000002Wml-3DjC; Tue, 28 Apr 2026 09:37:44 -0600 From: Tom Tromey To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org, tankut.baris.aktemur@intel.com Subject: Re: [PATCH 1/1] gdb: use waitpid directly in wait_to_die_with_timeout In-Reply-To: <20260420131255.3744-1-abdul.b.ijaz@intel.com> (Abdul Basit Ijaz's message of "Mon, 20 Apr 2026 15:12:55 +0200") References: <20260420131255.3744-1-abdul.b.ijaz@intel.com> X-Attribution: Tom Date: Tue, 28 Apr 2026 09:37:43 -0600 Message-ID: <87mrynm6yg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wHkVM-00000002Wml-3DjC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:47016 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJ4GCo5g1O+w1rkWiZC3IyMvu7HgIKgpClvHvw3Etiq11YtVNonBzaiDxj1DI9JrnahkBDOXYgFPCNNw0MItiTfQ+V7K6N5EDEKXUTaC6rzHmjBb4Ly7 1W8rBjQELMnXtg4rzrSHmkV3Fl6bjBcZTsFDPiookrk2/9KxC8OYdpZz12BwaA1F/BK8QJcECvIF5hnmzoR5HU9stKyobjf6N74= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Abdul Basit Ijaz writes: > This is a regression since commit "[gdb] Use gdb::waitpid more often", > before which GDB was giving the prompt after a timeout. The reason is > in wait_to_die_with_timeout GDB calls gdb::waitpid to wait for > gdbserver with an interrupt timeout set by an alarm call. In > gdb::waitpid, we call gdb::handle_eintr, which repeatedly makes the > syscall if it's interrupted. In this case, however, we wouldn't want > to repeat the waitpid if the timeout expired. Hence, go back to using > waitpid directly, instead of gdb::waitpid, to restore the previous > behavior. Makes sense. Thanks. Approved-By: Tom Tromey Tom