Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb] Fix hard-coded constants in buildsym_compunit::make_blockvector
Date: Fri, 17 Jul 2026 08:20:27 -0600	[thread overview]
Message-ID: <87mrvpy9xw.fsf@tromey.com> (raw)
In-Reply-To: <20260716165659.1416919-1-tdevries@suse.de> (Tom de Vries's message of "Thu, 16 Jul 2026 18:56:59 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Fix this by rewriting it into an ordinary descending for loop, and using
Tom> symbolic constant GLOBAL_BLOCK to avoid the global block:
Tom> ...
Tom>       for (int j = num_blocks - 1; j > GLOBAL_BLOCK; --j)
Tom>  	{
Tom>  	  struct block *b = blockvector->block (j);

Thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

      reply	other threads:[~2026-07-17 14:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 16:56 Tom de Vries
2026-07-17 14:20 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mrvpy9xw.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox