From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wjYwEFA6WmoVxQ4AWB0awg (envelope-from ) for ; Fri, 17 Jul 2026 10:21:04 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Fkf8n9V5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 298171E09E; Fri, 17 Jul 2026 10:21:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 504B61E033 for ; Fri, 17 Jul 2026 10:21:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 677124BA2E1C for ; Fri, 17 Jul 2026 14:21:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 677124BA2E1C Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Fkf8n9V5 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 5A7794BA2E0A for ; Fri, 17 Jul 2026 14:20:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5A7794BA2E0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5A7794BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784298037; cv=none; b=lE0aL+1rXEPMci3b8hsgl8P/14RrvYgBQuEXBDo9aNvBoTqt635wj+vKS1zbfidWSU/2RapyGe/IdG3mMxjDJ0xM6+wcVILjoXeyKh/xRQI3V6XtSZ15AqeoSh35vNxO3qpPq2vsHR6pyb0G00DRV1gNeAv/Cjg6zbeCvuxuR5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784298037; c=relaxed/simple; bh=xbBnvgrP9+/bNUetP1DlSG2Y0bqjunhZzxuUHd1pfyY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sDMfb0tnHUf15ekE0aEm/9U6+hSYYRn1N2DMeRuPh7sVblgdWwXnYmW3LmVsNU113xV6d4mLlXADI7kxEglsb9iMadQMuoKAM5A9HWOPNXqTYAVD84+tTkikE8n5N05BK67oL+LiSxqmXQW7Y0ff8klRz2jkSxC92h6sQT2SC3I= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Fkf8n9V5 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A7794BA2E0A Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id kigiwj3DbaC0UkjQawMrPL; Fri, 17 Jul 2026 14:20:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kjQYw1SGyJzb7kjQYwORNw; Fri, 17 Jul 2026 14:20:34 +0000 X-Authority-Analysis: v=2.4 cv=Quhe3Uyd c=1 sm=1 tr=0 ts=6a5a3a32 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=RAioF0-LDSMA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=0Q4ecZ-Y7ivdfqCpp68A:9 a=zZCYzV9kfG8A:10 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=D3qpiWAlEUsATuF4JT9PrHlmEZBQDhinCuYON0wmu74=; b=Fkf8n9V5MYJkKHSD/MrzYOqUUb a+iVrSFj7lD+GNco0hQaukoHp72yH/hgz1NnWHxE6+POLbZnA5Ieu8UUlPjennot93O7sIy5Oxiry wDDFhJYVwpOU/Mm2ieOuqJ5LC; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:55498 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wkjQY-00000000HlC-0zlF; Fri, 17 Jul 2026 08:20:34 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb] Fix hard-coded constants in buildsym_compunit::make_blockvector In-Reply-To: <20260716165659.1416919-1-tdevries@suse.de> (Tom de Vries's message of "Thu, 16 Jul 2026 18:56:59 +0200") References: <20260716165659.1416919-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 17 Jul 2026 08:20:27 -0600 Message-ID: <87mrvpy9xw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wkjQY-00000000HlC-0zlF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:55498 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLOHza2jTjRzB/INxptJVxHQxGaw1rc5ioUXZYJ6UQCfZgTLSaXIpDN+ex2ladu/WLd59W4BvcgU2N53v9HtPXivhLiUcXKjSEyypMWDyKFfyov36wFT Hp0h3A2vC8Ux6R/63Eikz6t7HBGhidRjO8m03pW+fLNBHE4IRrp1Bjkv2ZOb4vFq50qhpBI2wKyDBSwVE02axI5nfmg+O7YUfDQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> Fix this by rewriting it into an ordinary descending for loop, and using Tom> symbolic constant GLOBAL_BLOCK to avoid the global block: Tom> ... Tom> for (int j = num_blocks - 1; j > GLOBAL_BLOCK; --j) Tom> { Tom> struct block *b = blockvector->block (j); Thanks. Approved-By: Tom Tromey Tom