Re: [PATCH 1/3] Remove stale pre-AIX-7.2 compatibility guards

[Tom Tromey <tom@tromey.com>]

>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:

> From: Aditya Vidyadhar Kamath <aditya.kamath1@ibm.com>
> GDB now requires AIX 7.2 as the minimum supported version and will
> support AIX 7.2 TL5, AIX 7.3 and upcoming AIX releases.  Remove
> dead compatibility code that existed only for older releases.

Hi.  I saw this and had a few comments.

> -#if !HAVE_DECL_GETTHRDS
> -extern int getthrds (pid_t, struct thrdsinfo64 *, int, tid_t *, int);
> -#endif

I think this is the last use of HAVE_DECL_GETTHRDS, so the corresponding
configure check can be removed:

	 # Older versions of AIX do not provide the declaration for
	 # the getthrds function (it appears that it was introduced
	 # with AIX 6.x).
	 AC_CHECK_DECLS(getthrds, [], [], [[#include <procinfo.h>]])

>  static int
>  ptrace64aix (int req, int id, long long addr, int data, int *buf)
>  {
>    errno = 0;
> -  return ptrace_check (req, id, ptracex (req, id, addr, data, buf));
> +  return ptrace_check (req, id, ptrace64 (req, id, addr, data, buf));

>  static int
> -ptrace32 (int req, int id, addr_ptr addr, int data, int *buf)
> +ptrace32 (int req, int id, long long addr, int data, int *buf)
>  {
>    errno = 0;
> -  return ptrace_check (req, id,
> -		       ptrace (req, id, addr, data, buf));
> +  return ptrace_check (req, id, ptrace64 (req, id, addr, data, buf));

AFAICT ptrace64aix and ptrace32 are now identical.  If this is
intentional then I think they could be combined.  But then it looks like
they could also just be merged into ptrace_check as well.

If that's done then there are other spots that could be simplified, for
example:

  if (flags & PTHDB_FLAG_GPRS)
    {
      if (data->arch64)
	ptrace64aix (PTT_WRITE_GPRS, tid,
		     (unsigned long) context->gpr, 0, NULL);
      else
	ptrace32 (PTT_WRITE_GPRS, tid, (uintptr_t) context->gpr, 0, NULL);
    }

In gdb it's very unusual to use "long long" here but OTOH the rules are
more lax for native code.  So I don't know if that's a problem.

thanks,
Tom