From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pCACJnKyqmopvBIAWB0awg (envelope-from ) for ; Wed, 16 Sep 2026 11:14:58 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TN7mBfo0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 88A851E06B; Wed, 16 Sep 2026 11:14:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9D5DD1E01F for ; Wed, 16 Sep 2026 11:14:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD7224BA9037 for ; Wed, 16 Sep 2026 15:14:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD7224BA9037 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TN7mBfo0 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 6E4DC4BA23DC for ; Wed, 16 Sep 2026 15:14:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E4DC4BA23DC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6E4DC4BA23DC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789571672; cv=none; b=GUOdG9BHjOWUXj5Aa5XUw9SQ5pCsmmqkkS7uFPC+LcxxHn2g83aH2PbVSMTivMPSou4nwuUbTa2Pwa0o5QcR3D5eaxz6EGN05qY3CUPH/wgz0udHNAW1eZ8/Q1RI6OICoOXnddsonE3suNgmSTtcdN9fIcUGwheljxUACv2llzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789571672; c=relaxed/simple; bh=eoPK6DPcwWpsFdF5pfIeTsn/hlQa9IMIznpIhZH1tS4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PhfyzQZmdEhuQoxFUwIED/DUVYYuS1YKfbHmXGNGG4W66O/YPGiBnHniuAktWl0Q0QA8ChPilmPYFggdtetGCsBsQUpaBj7I+nqyYUrpCC5DTdXsm3f8DiUocRAWIW9B5VlV3xls4C0Lx5lUjYET2nwWR+3dp4UH2+h1LCz9hAY= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TN7mBfo0 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6E4DC4BA23DC Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id 6on5xSj9ic3Xs6rLDxII9O; Wed, 16 Sep 2026 15:14:31 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6rLCxvICi8TJY6rLCxVW81; Wed, 16 Sep 2026 15:14:31 +0000 X-Authority-Analysis: v=2.4 cv=S9vZwJsP c=1 sm=1 tr=0 ts=6aaab257 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=VnNF1IyMAAAA:8 a=ZAWTCiRIc8-pkxCtUzAA:9 a=O8hF6Hzn-FEA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZaUKoEy0T9b6mZongfQwRvxA8jcFq3Bhn/Uhie4QbH4=; b=TN7mBfo0qQDq0/cqbRVc+yMesi IaaQYKNpU25X7msE0tphZsEjFd6CrsbmltEHy+tZYGptS9mCXxLUh+aBOsCTvoJJheg+l5gDtTZzj 0moE61vDh5O7A4Qk4gwfvYAal; Received: from 75-166-229-74.hlrn.qwest.net ([75.166.229.74]:38326 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x6rLC-00000002nsN-2jq7; Wed, 16 Sep 2026 09:14:30 -0600 From: Tom Tromey To: Aditya Vidyadhar Kamath Cc: ulrich.weigand@de.ibm.com, simon.marchi@polymtl.ca, tom@tromey.com, gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com Subject: Re: [PATCH 1/3] Remove stale pre-AIX-7.2 compatibility guards In-Reply-To: <20260916114519.17472-2-akamath996@gmail.com> (Aditya Vidyadhar Kamath's message of "Wed, 16 Sep 2026 17:15:20 +0530") References: <20260916114519.17472-2-akamath996@gmail.com> X-Attribution: Tom Date: Wed, 16 Sep 2026 09:14:27 -0600 Message-ID: <87mrthut2k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.229.74 X-Source-L: No X-Exim-ID: 1x6rLC-00000002nsN-2jq7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-229-74.hlrn.qwest.net (bapiya) [75.166.229.74]:38326 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEcLFsKSd4m1eeEAvvOptsewQtEbv/uYBZfr8L5rlSnMH7KAq3uiN46s1Uo2xXH/EVrx5oBEcEeT4F/Ghe3jCH4fb5LDMlSIo3dl+LGK+jZ2qHIBdDGR d95I5nKyyJgbA0+aaqWGU/3QEHOkS6qMpPuOYGMZMisS7dLPrl11IKYvhjhQ+s4IUl8EI3upplmI8g8FonJxnuFJsqofWlHf7+o= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Aditya Vidyadhar Kamath writes: > From: Aditya Vidyadhar Kamath > GDB now requires AIX 7.2 as the minimum supported version and will > support AIX 7.2 TL5, AIX 7.3 and upcoming AIX releases. Remove > dead compatibility code that existed only for older releases. Hi. I saw this and had a few comments. > -#if !HAVE_DECL_GETTHRDS > -extern int getthrds (pid_t, struct thrdsinfo64 *, int, tid_t *, int); > -#endif I think this is the last use of HAVE_DECL_GETTHRDS, so the corresponding configure check can be removed: # Older versions of AIX do not provide the declaration for # the getthrds function (it appears that it was introduced # with AIX 6.x). AC_CHECK_DECLS(getthrds, [], [], [[#include ]]) > static int > ptrace64aix (int req, int id, long long addr, int data, int *buf) > { > errno = 0; > - return ptrace_check (req, id, ptracex (req, id, addr, data, buf)); > + return ptrace_check (req, id, ptrace64 (req, id, addr, data, buf)); > static int > -ptrace32 (int req, int id, addr_ptr addr, int data, int *buf) > +ptrace32 (int req, int id, long long addr, int data, int *buf) > { > errno = 0; > - return ptrace_check (req, id, > - ptrace (req, id, addr, data, buf)); > + return ptrace_check (req, id, ptrace64 (req, id, addr, data, buf)); AFAICT ptrace64aix and ptrace32 are now identical. If this is intentional then I think they could be combined. But then it looks like they could also just be merged into ptrace_check as well. If that's done then there are other spots that could be simplified, for example: if (flags & PTHDB_FLAG_GPRS) { if (data->arch64) ptrace64aix (PTT_WRITE_GPRS, tid, (unsigned long) context->gpr, 0, NULL); else ptrace32 (PTT_WRITE_GPRS, tid, (uintptr_t) context->gpr, 0, NULL); } In gdb it's very unusual to use "long long" here but OTOH the rules are more lax for native code. So I don't know if that's a problem. thanks, Tom