From: Tom Tromey <tromey@redhat.com>
To: xgsa <xgsa@yandex.ua>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
Vladimir_Prus@mentor.com
Subject: Re: [patch] Use the string returned by pretty printer for MI varobjs instead of "{...}"
Date: Tue, 15 May 2012 16:28:00 -0000 [thread overview]
Message-ID: <87likttnme.fsf@fleche.redhat.com> (raw)
In-Reply-To: <305151335125397@web28e.yandex.ru> (xgsa@yandex.ua's message of "Mon, 23 Apr 2012 00:09:57 +0400")
>>>>> "Anton" == xgsa <xgsa@yandex.ua> writes:
Anton> The documentation for -var-create says that "for a varobj whose type
Anton> is some sort of aggregate (e.g., a struct), or for a dynamic varobj,
Anton> the 'value' attribute will not be interesting". That's not true, as
Anton> dynamic varobj could also have no children (so its value will be not
Anton> "{...}" and will be interesting). However I think the string value of
Anton> varobj that has pretty printer installed should always be returned via
Anton> MI. It could contain such a useful information as container length or
Anton> reference count for smart pointers. Moreover, it seems that this
Anton> information cannot be accessed via MI in another way. This patch
Anton> contains the proposed fix, documentation and test suite update.
The patch itself looks fine, but I am not sure whether it should go in.
My recollection is that the code originally worked this way, but
Vladimir asked for the "{...}" behavior specifically.
I've CC'd him for comments.
I am in favor of this change, as I never understood the current
behavior; so in the absence of comments I will approve it.
I'm sorry about the delay.
Tom
next prev parent reply other threads:[~2012-05-15 16:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 20:17 xgsa
2012-04-27 18:51 ` xgsa
2012-05-03 6:51 ` xgsa
2012-05-03 14:57 ` Joel Brobecker
2012-05-08 6:40 ` xgsa
2012-05-15 5:45 ` xgsa
2012-05-04 7:45 ` Eli Zaretskii
2012-05-15 16:28 ` Tom Tromey [this message]
2012-05-16 1:05 ` André Pönitz
2012-05-16 14:59 ` Tom Tromey
2012-05-17 12:19 ` André Pönitz
2012-05-17 12:58 ` Vladimir Prus
2012-05-17 19:07 ` xgsa
2012-05-21 19:04 ` xgsa
2012-05-17 15:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87likttnme.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Vladimir_Prus@mentor.com \
--cc=gdb-patches@sourceware.org \
--cc=xgsa@yandex.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox