From: xgsa <xgsa@yandex.ru>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: "André Pönitz" <andre.poenitz@mathematik.tu-chemnitz.de>,
"Tom Tromey" <tromey@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] Use the string returned by pretty printer for MI varobjs instead of "{...}"
Date: Mon, 21 May 2012 19:04:00 -0000 [thread overview]
Message-ID: <4FBA91C7.1050909@yandex.ru> (raw)
In-Reply-To: <4FB54C71.5060205@yandex.ru>
So could I check this patch in or not? I have written my arguments for
these changes, Vladimir has written his ones against them. It seems Tom
in favor of these changes too. So what is the final decision? Could
somebody say "these changes are approved" or "no, these changes should
not go in" or what should be done in such cases?
Thanks,
Anton
-------- Original message --------
>> I has been quite a while, but I think I was primarily concerned that
>> GDB would abuse value string on varobj
>> to show what GDB thinks is the right rendering of data. E.g. while
>> "[5]" as top-level value might be a reasonable
>> rendition for an array with 5 children, it's not entirely clear why
>> GDB's machine interface should take liberties
>> at telling frontend how to render that. Neither "[", nor 5, nor "]"
>> is integral part of data, and as soon as
>> GDB outputs that, frontend has no way of knowing whether this is GDB
>> trying to be helpful, or really interesting
>> data that cannot be obtained in any other way.
>
> I cannot figure out why the frontend need to know it? I think, it
> should just output what GDB returns, cause GDB knows better how to
> visualize the concrete data type due to pretty printers mechanism.
> Otherwise, the frontend should have something similar to pretty
> printers that will visualize different types in a comfortable way. In
> any case if the implemented behavior is not desirable the string()
> method of pretty printer could be left unimplemented (or return None).
> It will give the behavior you described above, but could also be
> extended if necessary.
>
>
> Thanks,
> Anton
>
>
next prev parent reply other threads:[~2012-05-21 19:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 20:17 xgsa
2012-04-27 18:51 ` xgsa
2012-05-03 6:51 ` xgsa
2012-05-03 14:57 ` Joel Brobecker
2012-05-08 6:40 ` xgsa
2012-05-15 5:45 ` xgsa
2012-05-04 7:45 ` Eli Zaretskii
2012-05-15 16:28 ` Tom Tromey
2012-05-16 1:05 ` André Pönitz
2012-05-16 14:59 ` Tom Tromey
2012-05-17 12:19 ` André Pönitz
2012-05-17 12:58 ` Vladimir Prus
2012-05-17 19:07 ` xgsa
2012-05-21 19:04 ` xgsa [this message]
2012-05-17 15:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA91C7.1050909@yandex.ru \
--to=xgsa@yandex.ru \
--cc=andre.poenitz@mathematik.tu-chemnitz.de \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox