From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
gdb-patches <gdb-patches@sourceware.org>,
Cary Coutant <ccoutant@google.com>
Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
Date: Tue, 05 Nov 2013 03:42:00 -0000 [thread overview]
Message-ID: <87li13shk2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CADPb22QKBpYpmmZzeKJy7JWukpfkTQcYZDm+KeEkr6K_92LJ2A@mail.gmail.com> (Doug Evans's message of "Mon, 4 Nov 2013 14:21:33 -0800")
>> (void)
Doug> We don't have any such style rules for testcases.
Doug> But ok, done.
Doug> Going forward though, for my own patch reviews of other people's code,
Doug> what's the story here?
In this case, "()" is not idiomatic C, whereas "(void)" is.
This is not the same as a coding style rule.
Tom
next prev parent reply other threads:[~2013-11-05 2:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 23:26 Doug Evans
2013-10-30 23:57 ` Doug Evans
2013-10-31 16:42 ` Jan Kratochvil
2013-11-04 22:38 ` Doug Evans
2013-11-04 23:04 ` Cary Coutant
2013-11-05 3:42 ` Tom Tromey [this message]
2013-11-05 17:22 ` Doug Evans
2013-11-05 17:23 ` Jan Kratochvil
2013-11-05 18:01 ` Doug Evans
2013-11-05 18:13 ` Jan Kratochvil
2013-11-06 21:16 ` Doug Evans
2013-11-06 21:28 ` Jan Kratochvil
2013-11-07 1:05 ` Stan Shebs
2013-11-07 18:01 ` Doug Evans
2013-11-07 19:03 ` Jan Kratochvil
2013-11-08 17:57 ` Doug Evans
2013-11-08 19:17 ` Jan Kratochvil
2013-11-12 18:46 ` Doug Evans
2013-11-12 19:58 ` Jan Kratochvil
2013-11-12 22:05 ` Doug Evans
2013-11-05 17:32 ` Pedro Alves
2013-11-05 17:32 ` Tom Tromey
2013-11-05 17:04 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li13shk2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=ccoutant@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox