From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106903-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31719 invoked by alias); 5 Nov 2013 02:34:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31708 invoked by uid 89); 5 Nov 2013 02:34:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2013 02:34:15 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA52Y62G031010	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 4 Nov 2013 21:34:06 -0500
Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rA52Y5c0002309	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 4 Nov 2013 21:34:06 -0500
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,        gdb-patches <gdb-patches@sourceware.org>,        Cary Coutant <ccoutant@google.com>
Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
References: <yjt24n85x78h.fsf@ruffy.mtv.corp.google.com>	<20131031154957.GA11260@host2.jankratochvil.net>	<CADPb22QKBpYpmmZzeKJy7JWukpfkTQcYZDm+KeEkr6K_92LJ2A@mail.gmail.com>
Date: Tue, 05 Nov 2013 03:42:00 -0000
In-Reply-To: <CADPb22QKBpYpmmZzeKJy7JWukpfkTQcYZDm+KeEkr6K_92LJ2A@mail.gmail.com>	(Doug Evans's message of "Mon, 4 Nov 2013 14:21:33 -0800")
Message-ID: <87li13shk2.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-11/txt/msg00070.txt.bz2

>> (void)

Doug> We don't have any such style rules for testcases.
Doug> But ok, done.

Doug> Going forward though, for my own patch reviews of other people's code,
Doug> what's the story here?

In this case, "()" is not idiomatic C, whereas "(void)" is.
This is not the same as a coding style rule.

Tom