From: Tom Tromey <tom@tromey.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow DW_OP_GNU_uninit in dwarf_expr_require_composition
Date: Sun, 09 Oct 2016 17:36:00 -0000 [thread overview]
Message-ID: <87lgxxctli.fsf@tromey.com> (raw)
In-Reply-To: <m3lh3zuf30.fsf@oc1027705133.ibm.com> (Andreas Arnez's message of "Wed, 27 Apr 2016 19:38:43 +0200")
>>>>> "Andreas" == Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
Andreas> This patch allows DW_OP_GNU_uninit after all operators
Andreas> requiring a composition, to simplify the code and make it more
Andreas> consistent. This policy may be more permissive than necessary,
Andreas> but in the worst case just leads to a DWARF location
Andreas> description resulting in an uninitialized value instead of an
Andreas> error message.
I think it would be best to allow DW_OP_GNU_uninit to terminate any
piece, rather than require it to be at the end of the expression. This
seems compatible and clearly more consistent with other DWARF
operations.
That is, assuming DW_OP_GNU_uninit is useful at all.
Another option would be to deprecate it.
Tom
next prev parent reply other threads:[~2016-10-09 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 17:38 Andreas Arnez
2016-10-04 17:33 ` Pedro Alves
2016-10-05 10:42 ` Andreas Arnez
2016-10-09 17:36 ` Tom Tromey [this message]
2016-10-10 12:24 ` Andreas Arnez
2016-10-10 22:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgxxctli.fsf@tromey.com \
--to=tom@tromey.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox