From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21974 invoked by alias); 9 Oct 2016 17:36:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21961 invoked by uid 89); 9 Oct 2016 17:36:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=composition, Hx-spam-relays-external:sk:gproxy4, Hx-spam-relays-external:69.89.23.142, H*RU:69.89.23.142 X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Sun, 09 Oct 2016 17:36:47 +0000 Received: (qmail 458 invoked by uid 0); 9 Oct 2016 17:36:45 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy4.mail.unifiedlayer.com with SMTP; 9 Oct 2016 17:36:45 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id tVci1t00N2f2jeq01VcliB; Sun, 09 Oct 2016 11:36:45 -0600 X-Authority-Analysis: v=2.1 cv=IecUBwaa c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=VnNF1IyMAAAA:8 a=U3dkial7kl6YPs6KuAEA:9 a=skCgnbhlp52w9zbo2JeP:22 Received: from c-67-176-62-53.hsd1.co.comcast.net ([67.176.62.53]:41122 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1btI1i-0007RF-8H; Sun, 09 Oct 2016 11:36:42 -0600 From: Tom Tromey To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Allow DW_OP_GNU_uninit in dwarf_expr_require_composition References: Date: Sun, 09 Oct 2016 17:36:00 -0000 In-Reply-To: (Andreas Arnez's message of "Wed, 27 Apr 2016 19:38:43 +0200") Message-ID: <87lgxxctli.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1btI1i-0007RF-8H X-Source-Sender: c-67-176-62-53.hsd1.co.comcast.net (bapiya) [67.176.62.53]:41122 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00203.txt.bz2 >>>>> "Andreas" == Andreas Arnez writes: Andreas> This patch allows DW_OP_GNU_uninit after all operators Andreas> requiring a composition, to simplify the code and make it more Andreas> consistent. This policy may be more permissive than necessary, Andreas> but in the worst case just leads to a DWARF location Andreas> description resulting in an uninitialized value instead of an Andreas> error message. I think it would be best to allow DW_OP_GNU_uninit to terminate any piece, rather than require it to be at the end of the expression. This seems compatible and clearly more consistent with other DWARF operations. That is, assuming DW_OP_GNU_uninit is useful at all. Another option would be to deprecate it. Tom