From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Manish Goregaokar <manish@mozilla.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix handling of discriminantless univariant enums in Rust
Date: Sun, 30 Oct 2016 02:53:00 -0000 [thread overview]
Message-ID: <87lgx6wntm.fsf@tromey.com> (raw)
In-Reply-To: <87pomiwo1z.fsf@tromey.com> (Tom Tromey's message of "Sat, 29 Oct 2016 20:47:20 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> Also, I suspect this will wind up doing the wrong thing in the
Tom> STRUCTOP_ANONYMOUS case in rust_evaluate_subexp. In particular I wonder
Tom> if an additional "print univariant.0.a" test will work correctly?
Oh duh, I see that this isn't a correct counter-example.
What about just "print univariant.a"?
It seems to me that this will hit this:
start = disr.is_encoded ? 0 : 1;
... choosing 1 here, but:
for (i = start; i < TYPE_NFIELDS (variant_type); i++)
... failing this because TYPE_NFIELDS == 1; and then:
if (i == TYPE_NFIELDS (variant_type))
/* We didn't find it. */
error(_("Could not find field %s of struct variant %s"),
Tom
next prev parent reply other threads:[~2016-10-30 2:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 23:52 Manish Goregaokar
2016-10-28 19:57 ` Manish Goregaokar
2016-10-30 2:48 ` Tom Tromey
2016-10-30 2:53 ` Tom Tromey [this message]
2016-10-30 2:58 ` Manish Goregaokar
2016-10-30 3:06 ` Manish Goregaokar
2016-10-30 3:34 ` Tom Tromey
2016-10-30 3:36 ` Manish Goregaokar
2016-10-30 3:40 ` Manish Goregaokar
2016-10-31 3:03 ` Tom Tromey
2016-10-31 3:20 ` Manish Goregaokar
2016-10-31 3:29 ` Tom Tromey
2016-10-31 3:47 ` Manish Goregaokar
2016-10-31 6:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgx6wntm.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=manish@mozilla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox