Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Manish Goregaokar <manish@mozilla.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix handling of discriminantless univariant enums in Rust
Date: Mon, 31 Oct 2016 03:03:00 -0000	[thread overview]
Message-ID: <874m3tw784.fsf@tromey.com> (raw)
In-Reply-To: <CAFOnWk=cUZfUzn9a4qp_nw8aFxkGWx3TSOGapH7HmOfWAeoSRg@mail.gmail.com>	(Manish Goregaokar's message of "Sat, 29 Oct 2016 20:39:48 -0700")

>>>>> "Manish" == Manish Goregaokar <manish@mozilla.com> writes:

Manish> +  else if (TYPE_NFIELDS (type) == 1) {
Manish> +    /* Sometimes univariant enums are encoded without a
Manish> +    discriminant. In that case, treating it as an encoded enum
Manish> +    with the first field being the actual type works.  */
Manish> +    const char* field_name = TYPE_NAME (TYPE_FIELD_TYPE (type, 0));
Manish> +    ret.name = concat (TYPE_NAME (type), "::",
Manish> +                       rust_last_path_segment (field_name),
Manish> +                       (char *) NULL);
Manish> +    ret.field_no = RUST_ENCODED_ENUM_REAL;
Manish> +    ret.is_encoded = 1;
Manish> +    return ret;
Manish> +  }
Manish>    if (strcmp (TYPE_FIELD_NAME (disr_type, 0), "RUST$ENUM$DISR") != 0)

This still should follow GNU style.
And I think a blank line after the "}".

Manish> +gdb_test "print parametrized.next.val" " =
Manish> \\(simple::ParametrizedStruct<i32> \\*\\) $hex"

Patch mangled by mail program.
No biggie but it's a pain if one wants to try it out.

Manish> $hex\\}, value: 0\\}"
Manish> \ No newline at end of file

Please add a newline.

Tom


  reply	other threads:[~2016-10-31  3:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27 23:52 Manish Goregaokar
2016-10-28 19:57 ` Manish Goregaokar
2016-10-30  2:48 ` Tom Tromey
2016-10-30  2:53   ` Tom Tromey
2016-10-30  2:58     ` Manish Goregaokar
2016-10-30  3:06       ` Manish Goregaokar
2016-10-30  3:34       ` Tom Tromey
2016-10-30  3:36         ` Manish Goregaokar
2016-10-30  3:40           ` Manish Goregaokar
2016-10-31  3:03             ` Tom Tromey [this message]
2016-10-31  3:20               ` Manish Goregaokar
2016-10-31  3:29                 ` Tom Tromey
2016-10-31  3:47                   ` Manish Goregaokar
2016-10-31  6:17                     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m3tw784.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=manish@mozilla.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox