From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/8] Add gdb_ref_ptr.h
Date: Tue, 13 Dec 2016 13:13:00 -0000 [thread overview]
Message-ID: <87lgvkezyt.fsf@tromey.com> (raw)
In-Reply-To: <13207c13-89b0-c5e3-fbd8-05cc19fda4b2@redhat.com> (Pedro Alves's message of "Sat, 3 Dec 2016 00:04:49 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> BTW, I noticed today that the GCC standards say:
Pedro> "Template parameter names should use CamelCase, following the C++
Pedro> Standard."
Pedro> and they do seem to follow it. I think it's a good idea.
Pedro> Would you mind adjusting accordingly?
No problem, I did that.
FWIW my personal style is also to use CamelCase for macro arguments.
Pedro> I also noticed the "self/other" naming in the global operators:
Pedro> +template<typename T, typename POLICY>
Pedro> +inline bool operator== (const ref_ptr<T, POLICY> &self,
Pedro> + const ref_ptr<T, POLICY> &other)
Pedro> +{
Pedro> I'd find it pedantically more correct to write lhs/rhs, since
Pedro> there's no actual this/self here. Could you tweak that too?
I did this too.
Tom
next prev parent reply other threads:[~2016-12-13 13:13 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 5:06 [RFA 0/8] C++-ification series #5 Tom Tromey
2016-11-29 5:06 ` [RFA 3/8] Introduce and use gdb::unlinker Tom Tromey
2016-12-02 13:17 ` Pedro Alves
2016-11-29 5:06 ` [RFA 4/8] Remove make_cleanup_discard_psymtabs Tom Tromey
2016-12-02 14:21 ` Pedro Alves
2016-11-29 5:06 ` [RFA 7/8] Use unique_xmalloc_ptr in execute_gdb_command Tom Tromey
2016-11-29 5:22 ` Tom Tromey
2016-12-15 3:49 ` Tom Tromey
2016-12-20 17:48 ` Pedro Alves
2016-12-20 18:13 ` Tom Tromey
2016-12-23 20:01 ` Tom Tromey
2017-01-10 17:59 ` Pedro Alves
2017-01-10 19:22 ` Tom Tromey
2016-12-20 23:31 ` Tom Tromey
2016-12-20 23:56 ` Pedro Alves
2016-12-22 14:50 ` Tom Tromey
2016-12-22 15:09 ` Pedro Alves
2016-12-22 15:29 ` Tom Tromey
2016-12-22 15:40 ` Pedro Alves
2016-12-02 14:49 ` Pedro Alves
2016-12-13 13:30 ` Tom Tromey
2016-11-29 5:06 ` [RFA 5/8] Add value_freer Tom Tromey
2016-12-02 14:24 ` Pedro Alves
2016-11-29 5:06 ` [RFA 2/8] Use class to manage BFD reference counts Tom Tromey
2016-12-02 13:05 ` Pedro Alves
2016-12-13 13:26 ` Tom Tromey
2016-12-15 4:12 ` Tom Tromey
2016-12-20 18:18 ` Pedro Alves
2016-12-20 17:19 ` [pushed] gdb: Constify solib_find (Re: [RFA 2/8] Use class to manage BFD reference counts) Pedro Alves
2016-12-20 18:05 ` Tom Tromey
2016-11-29 5:06 ` [RFA 6/8] Use value_freer in dwarf2_evaluate_loc_desc_full Tom Tromey
2016-12-02 14:45 ` Pedro Alves
2016-12-13 13:29 ` Tom Tromey
2016-12-20 14:49 ` Pedro Alves
2016-12-23 19:05 ` Tom Tromey
2016-12-23 19:59 ` Tom Tromey
2017-01-10 17:58 ` Pedro Alves
2016-12-23 19:59 ` Tom Tromey
2017-01-10 17:57 ` Pedro Alves
2016-11-29 5:06 ` [RFA 1/8] Add gdb_ref_ptr.h Tom Tromey
2016-12-02 13:08 ` Pedro Alves
2016-12-02 17:46 ` Tom Tromey
2016-12-02 18:11 ` Pedro Alves
2016-12-02 19:52 ` Tom Tromey
2016-12-02 23:45 ` Pedro Alves
2016-12-03 0:05 ` Pedro Alves
2016-12-13 13:13 ` Tom Tromey [this message]
2016-11-29 5:06 ` [RFA 8/8] Add constructor and destructor to demangle_parse_info Tom Tromey
2016-12-02 15:04 ` Pedro Alves
2016-12-13 13:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgvkezyt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox