From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121239 invoked by alias); 13 Dec 2016 13:13:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121222 invoked by uid 89); 13 Dec 2016 13:13:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*palves, H*Ad:U*tom, H*RU:CMOut01, Hx-spam-relays-external:CMOut01 X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Dec 2016 13:13:07 +0000 Received: from CMOut01 (cmgw2 [10.0.90.82]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 6AC79176FB3 for ; Tue, 13 Dec 2016 06:11:11 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id KRB61u00b2f2jeq01RB9AN; Tue, 13 Dec 2016 06:11:09 -0700 X-Authority-Analysis: v=2.1 cv=U4oBU4bu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=oh6zuy7HfJNY6ixu6kUA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 70-58-1-248.hlrn.qwest.net ([70.58.1.248]:37380 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cGmrL-0001ym-Rf; Tue, 13 Dec 2016 06:11:07 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/8] Add gdb_ref_ptr.h References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-2-git-send-email-tom@tromey.com> <13207c13-89b0-c5e3-fbd8-05cc19fda4b2@redhat.com> Date: Tue, 13 Dec 2016 13:13:00 -0000 In-Reply-To: <13207c13-89b0-c5e3-fbd8-05cc19fda4b2@redhat.com> (Pedro Alves's message of "Sat, 3 Dec 2016 00:04:49 +0000") Message-ID: <87lgvkezyt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cGmrL-0001ym-Rf X-Source-Sender: 70-58-1-248.hlrn.qwest.net (bapiya) [70.58.1.248]:37380 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00287.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> BTW, I noticed today that the GCC standards say: Pedro> "Template parameter names should use CamelCase, following the C++ Pedro> Standard." Pedro> and they do seem to follow it. I think it's a good idea. Pedro> Would you mind adjusting accordingly? No problem, I did that. FWIW my personal style is also to use CamelCase for macro arguments. Pedro> I also noticed the "self/other" naming in the global operators: Pedro> +template Pedro> +inline bool operator== (const ref_ptr &self, Pedro> + const ref_ptr &other) Pedro> +{ Pedro> I'd find it pedantically more correct to write lhs/rhs, since Pedro> there's no actual this/self here. Could you tweak that too? I did this too. Tom