From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix leak of set/show verbose doc, avoid xfree of static string
Date: Fri, 28 Dec 2018 16:45:00 -0000 [thread overview]
Message-ID: <87lg49ob11.fsf@tromey.com> (raw)
In-Reply-To: <20181228112644.28560-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Fri, 28 Dec 2018 12:26:44 +0100")
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> gdb/ChangeLog
Philippe> 2018-12-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
Philippe> * top.c (set_verbose): Free previous docs if doc_allocated.
Philippe> Internationalize messages. Set doc_allocated to 0.
Thanks for the patch. This is ok.
Philippe> + if (c->doc && c->doc_allocated)
Philippe> + xfree ((char *) c->doc);
Philippe> + if (showcmd->doc && showcmd->doc_allocated)
Philippe> + xfree ((char *) showcmd->doc);
Ideally I guess we'd have a better way of doing this. A lot of the CLI
machinery could use some cleanup, but for now this is still an "open"
struct.
Tom
next prev parent reply other threads:[~2018-12-28 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 11:26 Philippe Waroquiers
2018-12-28 16:45 ` Tom Tromey [this message]
2018-12-28 17:21 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg49ob11.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox