From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48823 invoked by alias); 28 Dec 2018 16:45:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48812 invoked by uid 89); 28 Dec 2018 16:45:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:755 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.192.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Dec 2018 16:45:33 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 7404E400C826C for ; Fri, 28 Dec 2018 09:56:54 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cvGNgrxp4YTGMcvGNgfa6b; Fri, 28 Dec 2018 10:45:31 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j90CXkar4oC7kmaRqWRhfnNv5bIOYJ2/YoAoz7hRZ4c=; b=o8BFknHHMuLgLMdW7bvMhudZ4U CY3C+AekE4diteBtmzCeFbvSRlsSbP3kKLpa6gMHNOgaWDIyze/fMfmNeptKzaZfcMXp8QCyVl7mN sqi853ywSOlzPg5y5QNhr4jVi; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:33728 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gcvGN-000Laz-Ie; Fri, 28 Dec 2018 10:45:31 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix leak of set/show verbose doc, avoid xfree of static string References: <20181228112644.28560-1-philippe.waroquiers@skynet.be> Date: Fri, 28 Dec 2018 16:45:00 -0000 In-Reply-To: <20181228112644.28560-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Fri, 28 Dec 2018 12:26:44 +0100") Message-ID: <87lg49ob11.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00388.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> gdb/ChangeLog Philippe> 2018-12-28 Philippe Waroquiers Philippe> * top.c (set_verbose): Free previous docs if doc_allocated. Philippe> Internationalize messages. Set doc_allocated to 0. Thanks for the patch. This is ok. Philippe> + if (c->doc && c->doc_allocated) Philippe> + xfree ((char *) c->doc); Philippe> + if (showcmd->doc && showcmd->doc_allocated) Philippe> + xfree ((char *) showcmd->doc); Ideally I guess we'd have a better way of doing this. A lot of the CLI machinery could use some cleanup, but for now this is still an "open" struct. Tom